1766011 - Investigate other edge cases where an empty file diff generates hunks

Status: RESOLVED FIXED

(Conduit :: moz-phab, task, P3)

Description

[Zeid [:zeid]]

Test cases need to be added for both git and mercurial that cover:

• adding empty files
• deleting empty files
• modifying empty files or their modes

In all above cases, Change.hunks should be an empty list.

Comment 1

[Graham Robertson [:grammar]]

Attachment: WIP: tests: update git tests to check hunks on empty file ops (Bug 1766011) r?sheehan

Comment 2

[Graham Robertson [:grammar]]

Attachment: tests: update hg int tests to check hunks on empty file ops (Bug 1766011) r?sheehan

Comment 3

[Graham Robertson [:grammar]]

Attachment: WIP: tests: update hg int tests to check hunks on empty file ops (Bug 1766011) r?sheehan

Depends on D150508

Comment 4

[Johan Lorenzo [:jlorenzo]]

Hey there! I stumbled upon a weird case too. :Kwan helped me a lot diagnosing it. I uploaded a pretty big patch with moz-phab. This patch contains a files moved around. Some of them are empty files. Per Kwan, moz-phab submitted a corrupted diff which prevents lando from landing it. More precisely, we get these errors from phab[1]. I left more info on the Phab revision itself[2].

I'm happy to provide more context if needed!

[1] https://phabricator.services.mozilla.com/D150362?download=true
[2] https://phabricator.services.mozilla.com/D150362#4925914

Comment 5

[Graham Robertson [:grammar]]

Attachment: tests: update git + hg int tests to check empty file ops (Bug 1766011) r?sheehan

Comment 6

[Graham Robertson [:grammar]]

Attachment: WIP: tests: update git + hg int tests to check empty file ops (Bug 1766011) r?sheehan,sheehan tests: update hg int test to use xfail (Bug 1766011) Differential Revision: https://phabricator.services.mozilla.com/D150766

Comment 7

[Graham Robertson [:grammar]]

Attachment: Bug 1766011 - update int tests to accomodate windows r=sheehan