1766031 - Player window doesn't respond to keyboard input when a non Firefox window has focus.

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Visit YouTube in Firefox Nightly, and open any video into Picture-in-Picture
2. Foreground another application.
3. Click on the Picture-in-Picture player window
4. Attempt to use the cursors to seek, or tab to keyboard focus

ER:

The keyboard inputs should be handled.

AR:

Keyboard input is ignored.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think this is a regression from bug 1599061.

Any ideas on what we could do here, mstange?

Comment 2

[Markus Stange [:mstange]]

Oh, I didn't realize the window responds to key events. Then we should probably back out that bug and look for a different solution.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to P2 as the bug is tracked by a release manager for the current nightly.
See Triage for Bugzilla for more information.
If you disagree, please discuss with a release manager.

Comment 4

[Eitan Isaacson [:eeejay]]

Out of curiosity is there a keyboard method to focus the PiP window in the first place?

Comment 5

[Eitan Isaacson [:eeejay]]

Setting to access-s3 because the PiP video is still controllable from its origin tab. Also questioning if there is a keyboard method of focusing the PiP window in the first place. If there isn't, this doesn't regress keyboard users, unfortunately :(

Comment 6

[Mike Conley (:mconley) (:⚙️)]

There is - it's effectively another browser window, so you can cycle through it with the window cycling shortcut on the OS (ex: Cmd-tilde on macOS).

Comment 7

[Eitan Isaacson [:eeejay]]

Ok, thanks.

In Linux it is some kind of special window that doesn't participate in alt+tab, you need to do ctrl+alt+tab. shrug

Comment 8

[Markus Stange [:mstange]]

Fixed by backout of bug 1599061.

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2022-04-22 Nightly build on macOS 11. Verified as fixed on Firefox 101.0b6(20220512193916), Nightly 102.0a1(20220512213051) on Ubuntu 20.04, Win10 64-bits and macOS 11.