Implement a linter to prefer full template over typedefs for JS::Handle/Rooted.
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Tracking
(firefox102 fixed)
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Regressed 1 open bug)
Details
Attachments
(1 file)
It's currently quite mixed everywhere. We need to make it consistent.
Updated•3 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
I hope the attachment provides the details.
It works with --enable-clang-plugin
but ./mach static-analysis check --fix
does not include the new checker. It seems the command uses the prebuilt one, can I tell it to use the in-source one to try the autofix?
Comment 4•2 years ago
|
||
I think you can use: https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/code_analysis/mach_commands.py#1025
You can build clang-tidy on try download he artifact and use that one.
Assignee | ||
Comment 5•2 years ago
|
||
Thanks, triggering toolchain-win64-clang-tidy
helped (which is only available with "Use full job list") and ./mach static-analysis install C:\Users\sasch\Downloads\clang-tidy.tar.zst
(which somehow failed to unzip at the first try but worked at repeated tries. It just unzips things to ./mozbuild/clang-tools/
, though.)
Comment 8•2 years ago
|
||
Backed out for SM bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/321035432ccb1878c1f1f83460fc088891d4cca0
Log link: https://treeherder.mozilla.org/logviewer?job_id=378008078&repo=autoland&lineNumber=1499
Comment 10•2 years ago
|
||
bugherder |
Assignee | ||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
The too many warnings hide compile errors from my eyes...
Comment 12•2 years ago
|
||
Oh, and if there are too many warnings in the rebuild sources, the compile errors may be discarded from the buffer of the terminal.
Assignee | ||
Comment 13•2 years ago
|
||
Bug 1769494 will reduce a lot of them, sorry for the inconvenience 😞
Comment 14•2 years ago
|
||
I think that you could've landed the patch for this bug with some silencer patches which reduce the warnings enough. I hope you'd do that at next time you do something similar.
Updated•2 years ago
|
Description
•