[wpt-sync] Sync PR 33758 - [LayoutNG] Column break token replacement with spanners
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33758 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33758
Details from upstream follow.
Alison Maher <almaher@microsoft.com> wrote:
[LayoutNG] Column break token replacement with spanners
In CL:2692357, we added logic to replace the column break token
in its parent's list of child break tokens (if it had been updated
as a result of OOF fragmentation). However, if there
was a spanner, and the spanner had a break token,
|current_column_index| would stay set to 0, and we would end up
thinking the first column was the last column in the parent's
list of children. We would then replace the second column's
break token with the updated break token of the first column.To fix this, set current_column_index to kNotFound by default,
and only look at the child break tokens if current_column_index
has been set to something else.Bug: 1314916
Change-Id: I05b3790f90e3f34d4015c57ac7bfca367778ffa9
Reviewed-on: https://chromium-review.googlesource.com/3603262
WPT-Export-Revision: 77e953c0a98bcd0dc049812dde96cc1b8bcdcca0
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests
Status Summary
Firefox
PASS: 2
Chrome
PASS: 2
Safari
PASS: 2
Description
•