Closed Bug 1766061 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33758 - [LayoutNG] Column break token replacement with spanners

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33758 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33758
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[LayoutNG] Column break token replacement with spanners

In CL:2692357, we added logic to replace the column break token
in its parent's list of child break tokens (if it had been updated
as a result of OOF fragmentation). However, if there
was a spanner, and the spanner had a break token,
|current_column_index| would stay set to 0, and we would end up
thinking the first column was the last column in the parent's
list of children. We would then replace the second column's
break token with the updated break token of the first column.

To fix this, set current_column_index to kNotFound by default,
and only look at the child break tokens if current_column_index
has been set to something else.

Bug: 1314916
Change-Id: I05b3790f90e3f34d4015c57ac7bfca367778ffa9
Reviewed-on: https://chromium-review.googlesource.com/3603262
WPT-Export-Revision: 77e953c0a98bcd0dc049812dde96cc1b8bcdcca0

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98f441dbb3cd
[wpt PR 33758] - [LayoutNG] Column break token replacement with spanners, a=testonly

https://hg.mozilla.org/mozilla-central/rev/98f441dbb3cd

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.