Closed Bug 1766065 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33759 - Fix a number of bugs in the ancestral popup algorithm

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33759
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix a number of bugs in the ancestral popup algorithm

Prior to this change, there were several corner cases that would not
be properly handled, such as an anchor element that contains the
invoker of a lower-level popup. In addition, with this change, any
element that has an invoking attribute* that points to a popup, even
if it was not used to open that popup, will still act as an ancestral
popup relationship, and will not cause that popup to be light dismissed
if clicked.

See:
https://github.com/openui/open-ui/issues/508

  • togglepopup for now, soon to also be showpopup and hidepopup

Bug: 1307772
Change-Id: I443ffd1884abfdb2856dc5d946323de4b83e20e4
Reviewed-on: https://chromium-review.googlesource.com/3601261
WPT-Export-Revision: 394ddb511dbb941c1292ad78634816a2e352d9b4

PR 33759 applied with additional changes from upstream: 27622a853844ef5d16b1e53f83a2db5cb46d2596, 78c1949b7adf253f562a768bc1c7d0184727f559
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

FAIL : 15
ERROR: 1

Chrome

OK : 1
PASS : 12
FAIL : 5

Safari

FAIL : 15
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-light-dismiss.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Clicking outside a popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a popup does not close that popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus outside the popup will dismiss the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Clicking inside a child popup shouldn't close either popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a parent popup should close child popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on anchor element (that isn't an invoking element) shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Dragging from an open popup outside an open popup should leave the popup open: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element should be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element that was not used to invoke the popup can still be part of the ancestor chain: FAIL (Chrome: FAIL, Safari: FAIL)
    • Scrolling within a popup should not close the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving focus back to the anchor element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to the active trigger element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to an inactive trigger element should also not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL (Chrome: FAIL, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopup(): FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/075df0e37f8a
[wpt PR 33759] - Fix a number of bugs in the ancestral popup algorithm, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2f613117bb96
[wpt PR 33759] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/075df0e37f8a
https://hg.mozilla.org/mozilla-central/rev/2f613117bb96

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.