1766152 - The pop-up window of “Remove All Logins” in "about:logins" is on the left side of the screen.

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P5)

Description

[creative854379]

Attachment: The pop-up window of “Remove All Logins” in "about:logins" is on the left side of the screen

[Affected versions]:

• Firefox Nightly 101.0a1 (2022-04-23) (64-bit)
• Firefox Release 99.0.1 (64-bit)

[Affected Platforms]:

• Windows 10 x64

[Steps to reproduce]:

1. Launch Firefox, and access "about:logins".
2. Click on the "..." Menu button.
3. Select the “Remove All Logins” option.
4. Observe the pop up window.

[Expected result]:

• window is in the center of the screen.

[Actual result]:

• window is on the left side of the screen.

Comment 1

[Peter Magyari (Desktop QA)]

I'm not sure if this is expected or not but it does seem like this is the only pop-up from the "..." about logins menu that does not appear in the center of the screen by default.

Comment 2

[Tim Giles [:tgiles]]

This is expected according to the UX specification for removing multiple logins. I could easily be persuaded that this needs to be centered like the other pop-up windows from the "..." menu that Peter mentioned in Comment #1.

:Serg, do you still want to keep this bug open? I can mentor it if you want.

Comment 3

[Sergey Galich [:serg]]

Yes, all dialogs must be aligned consistently. It's a good first bug.

We hope to rework layout later this year. UX specs are not clear on ultra wide monitor scenario.

This is very low priority though, mostly just to give new contributors something to play with. Whole dialog must be reworked a bit, I've filed Bug 1766482 for that.

Comment 4

[ryu.devcreations]

I've had a look at the bug at codetribute and it was tagged as good first bug.
Since it's my first time wanting to contribute to mozilla this seems like a good start.
Is it ok if i work on this one?

Comment 5

[Tim Giles [:tgiles]]

Ryu, feel free to work on this. If you need help either needinfo me, or you can reach out in the Passwords matrix channel https://chat.mozilla.org/#/room/#passwords:mozilla.org

Thanks for helping out!

Comment 6

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #passwords channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your style changes with mach run. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 7

[ryu.devcreations]

Attachment: Bug 1766152 - Add margin to container class to center the dialog box. Remove margin-inline-start and aling-self property also remove media queries for container class since they are no longer needed. r=tgiles

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6eff9e24b7f
Add margin to container class to center the dialog box. Remove margin-inline-start and aling-self property also remove media queries for container class since they are no longer needed. r=tgiles

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f6eff9e24b7f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This seems like a pretty safe uplift for Beta if you're inclined to do so.

Comment 11

[Tim Giles [:tgiles]]

We'll just let it ride the trains as normal, no need to uplift.

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 102.0a1 (Build ID: 20220510213954) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.04 x64.

• The “Remove All Logins” pop-up is centered displayed on the “about:logins” page.