1766154 - Firefox crash when click "Apply and Restart" button for "Restart Firefox to apply these changes" under "Language"

Status: UNCONFIRMED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[thinking962]

Attachment: Set Language and restart Firefox crash.mov

[Affected Versions]:

• 99.0.1 (64-bit)

[Affected Platforms]

• MacOS 10.13.6
• MacOS 10.15.7

[Steps to reproduce]:

1. Open the browser.
2. Navigate to the "about:preferences" page.
3. Scroll down to "Language".
4. Click the "Set Alternatives..." button.
5. Click the "Select a language to add..." dropdown.
6. Choose the language.
7. Click the "Add" button.
8. Repeat Step 5, Step 6, and Step 7 to add some languages.
9. Click the "OK" button.
10. Click the "Apply and Restart" button

[Expected results]:

• Firefox restarts and the language is set.

[Actual results]:

• Firefox crash.

Comment 1

[Francesco Lodolo [:flod]]

Please do not set flags, that's up to the bug triager or owner.

Comment 2

[soapOperatest]

I'm so sorry about it. Thanks for reminding!

(In reply to Francesco Lodolo [:flod] from comment #1)

Please do not set flags, that's up to the bug triager or owner.

Comment 3

[Francesco Lodolo [:flod]]

I can't reproduce this on my machine.

1. Does it happen on a fresh profile?
2. Do you have a crash in about:crashes after this happens?

Comment 4

[thinking962]

Attachment: crash.png

Comment 5

[thinking962]

(In reply to Francesco Lodolo [:flod] from comment #3)

I can't reproduce this on my machine.

1. Does it happen on a fresh profile?
2. Do you have a crash in about:crashes after this happens?

For question 1), it happens on both fresh profile and old profile. I tried it on two profiles, one is new, and one is the one I have used for a long time.

For question 2), yes I got a crash report.

Comment 6

[Francesco Lodolo [:flod]]

Please submit the report and link to it here in the bug once available (in general, it would be great to submit all crashes). A local crash can't be used for debugging.

Comment 7

[thinking962]

(In reply to Francesco Lodolo [:flod] from comment #6)

Please submit the report and link to it here in the bug once available (in general, it would be great to submit all crashes). A local crash can't be used for debugging.

https://crash-stats.mozilla.org/report/index/1befe7b0-0d1d-43b3-ab3e-64a7e0220424
I try it again right now. It still crashes. I have submitted the crash report and the link is here. Please check.

Comment 8

[Francesco Lodolo [:flod]]

Tentatively moving to Add-ons, give the AddonManager: Waiting to start provider shutdown..

I would note that I count 24 language packs. I've tried installing 4-5, without having the browser crash.

Comment 9

[vcarciu]

We tried to reproduce the issue on macOS 10.14 using FF 99.0.1 , but no crashes were encountered during testing on a fresh Firefox profile.

Comment 10

[Shane Caraveo (:mixedpuppy)]

I suspect this is the dictionaries rather than the langpacks. They can be large, and there a are a bunch of them. The background update checker is running trying to possibly update some of those, while firefox is trying to restart.

Can you try to reproduce with a large number of dictionaries installed (as well as langpack)?

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #10)

Can you try to reproduce with a large number of dictionaries installed (as well as langpack)?

In that case, I would try to install a few languages from this list, including German.
https://mozilla-l10n.github.io/firefox-dictionaries/

For some languages, after the langpack we try to install dictionaries as well.

Comment 12

[vcarciu]

Hello, following the steps from reporter I observed that if we are adding the languages in about:preferences, both lang packs and dictionaries were installed for that language.

I tried this scenario using more than 30 languages without encountering any crashes at restart.

Thanks,
Victor

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 14

[Tomislav Jovanovic :zombie]

This seems like a corner case with unusually high number of dictionaries and possibly a slow network connection.

Comment 15

[Rob Wu [:robwu]]

The data in the add-ons repository is cleared upon receiving the "intl:app-locales-changed" observer.

That in its turn triggers logic that fetches additional details from AMO over network (presumably to get the up-to-date localized versions), at
https://searchfox.org/mozilla-central/rev/da6a85e615827d353e5ca0e05770d8d346b761a9/toolkit/mozapps/extensions/internal/AddonRepository.jsm#542-574

Perhaps this bug is happening when the language changes are triggered in quick succession, which queues up network requests. Not sure what's going to happen when all of that happens around shutdown.

There are multiple aspects here:

1. The backgroundUpdateCheck method shouldn't run concurrently.
2. The fetch should be time-bound, to not indefinitely block shutdown.
3. We should evaluate whether it's really necessary to immediately fetch the localized data, or even as a shutdown blocker. E.g. it may be reasonable to not block shutdown, but fetch again at the next startup.