1766232 - test_timer.js uses unknown Services member properties

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

In test_timer.js there are a couple of accesses of Services.mainThreadEventTarget, however that is not available on Services and should probably be Services.tm.mainThreadEventTarget.

If this is fixed or not, it does not affect the test passing, which also makes me wonder if the test is actually testing what bug 1384041 intended it to test.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1384041

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Is this test even testing anything important anymore?

Comment 3

[Andreas Farre [:farre]]

So, the main thread event target is the default target, I think. So no, it probably doesn't.

Comment 4

[Mark Banner (:standard8)]

(In reply to Andreas Farre [:farre] from comment #3)

So, the main thread event target is the default target, I think. So no, it probably doesn't.

Should the whole test file be removed, or only parts of it?

Comment 5

[Andreas Farre [:farre]]

Attachment: Bug 1766232 - Remove tests using Services.mainThreadEventTarget. r=smaug!

These test were intended to use the planned, but dropped, one thread
per TabGroup feature. They used to dispatch timer callbacks to the
system group to test the labelling needed, but since TabGroups were
removed and the event target was changed to the main thread event
target, these tests actually test the same thing as the regular
non-target tests. This because nsITimer is created with a target which
just happens to be the mainThreadEventTarget.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0ff2b9fbcab
Remove tests using Services.mainThreadEventTarget. r=smaug

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a0ff2b9fbcab