1766322 - JavaScript Error: "TypeError: can't access property "remoteTab", browser.frameLoader is null" {file: "resource://gre/modules/GeckoViewWebExtension.jsm" line: 547}]

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As noticed while investigating a perma failure for our CDP support on Android I noticed that the following Javascript error in the adb logcat which actually causes our tests to fail which have Fission enabled. It wasn't visible by last week so I assume it's a recent regression.

04-25 22:14:44.486  7296  7322 E GeckoConsole: [JavaScript Error: "TypeError: can't access property "remoteTab", browser.frameLoader is null" {file: "resource://gre/modules/GeckoViewWebExtension.jsm" line: 547}]
04-25 22:14:44.486  7296  7322 E GeckoConsole: setTabActive@resource://gre/modules/GeckoViewWebExtension.jsm:547:9
04-25 22:14:44.486  7296  7322 E GeckoConsole: onEvent@resource://gre/modules/GeckoViewTab.jsm:219:29
04-25 22:14:44.486  7296  7322 E GeckoConsole: _dispatch@resource://gre/modules/GeckoViewModule.jsm:147:21
04-25 22:14:44.486  7296  7322 E GeckoConsole: onEvent@resource://gre/modules/GeckoViewModule.jsm:135:12

Agi, do you have an idea?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that a try build from April 19th was fine:
https://treeherder.mozilla.org/jobs?repo=try&revision=b5a0fe10649506996a9d0ce9bf3a15c8f4779997&searchStr=android

So probably a recent regression?

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

This is a regression from Bug 1753700, Cathy maybe we can also add a check for browser.frameLoader?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753700

Comment 4

[Dianna Smith [:diannaS]]

Is this affecting users or just breaking tests? Checking to see if it is something we need to prioritize for fx100 once fixed.

Comment 5

[Cathy Lu [:calu]]

Attachment: Bug 1766322 - Check browser.frameLoader for tab prioritization

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4233995982f
Check browser.frameLoader for tab prioritization r=geckoview-reviewers,agi

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbb7f90e083f
Lint fix. r=fix. CLOSED TREE

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b4233995982f
https://hg.mozilla.org/mozilla-central/rev/cbb7f90e083f

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

I think this can only affect system pages like about:, so I wouldn't think it's something we need to uplift.

Comment 10

[Chris Peterson [:cpeterson]]

Moving some WebExtension bugs to the GeckoView::Extensions component.