Closed Bug 1766527 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33801 - Add actual support for popup=hint and popup=async

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33801 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33801
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Add actual support for popup=hint and popup=async

This CL fleshes out the behavior of hints and async popups,
including differences in both "one at a time" and light-dismiss
functionality:

  • Async popups do not close any other popups, including other asyncs.
  • Async popups do not light dismiss.
  • Hints do not close popups, but do close other Hints. There can only
    be one hint visible at a time.
  • Hints are light dismissed, currently with the same triggers as
    popups.
  • Popups close hints when they open.
  • Asyncs and Hints can be opened on page load via initiallyopen.
  • Only one Popup or Hint may be auto-opened with initiallyopen.
  • Multiple Asyncs can be opened on load with initiallyopen.

See:
https://github.com/openui/open-ui/blob/main/research/src/pages/popup/popup.research.explainer.mdx

Bug: 1307772
Change-Id: I472f3e8231273ad02ae2f12342f4017e20fe30dc

Reviewed-on: https://chromium-review.googlesource.com/3606540
WPT-Export-Revision: 09749e7e92976a57c302570804a5207ca5937114

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 3
FAIL : 17[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 33[GitHub]
ERROR: 1

Chrome

OK : 4
PASS : 24
FAIL : 11

Safari

OK : 3
FAIL : 33
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-attribute-basic.tentative.html [wpt.fyi]
    • The .showPopup() and .hidePopup() work on a popup, case #0.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, case #1.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, case #2.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #0.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #1.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #2.: FAIL (Chrome: PASS, Safari: FAIL)
    • IDL attribute reflection: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup attribute value should be case insensitive: FAIL (Chrome: PASS, Safari: FAIL)
    • Changing attribute values for popup should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Changing attribute values should close open popups: FAIL (Chrome: FAIL, Safari: FAIL)
    • Removing a visible popup=popup element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing a visible popup=hint element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing a visible popup=async element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/popups/popup-initiallyopen.tentative.html [wpt.fyi]
    • The initiallyopen attribute should affect page load only: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/popups/popup-light-dismiss.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Clicking outside a popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a popup does not close that popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus outside the popup will dismiss the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Clicking inside a child popup shouldn't close either popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a parent popup should close child popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on anchor element (that isn't an invoking element) shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Dragging from an open popup outside an open popup should leave the popup open: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element should be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element that was not used to invoke the popup can still be part of the ancestor chain: FAIL (Chrome: FAIL, Safari: FAIL)
    • Scrolling within a popup should not close the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving focus back to the anchor element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to the active trigger element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to an inactive trigger element should also not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL (Chrome: FAIL, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopup(): FAIL (Chrome: FAIL, Safari: FAIL)
    • Light dismiss of mixed popup types: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/popups/popup-types.tentative.html [wpt.fyi]
    • hints and asyncs do not close popups: FAIL (Chrome: FAIL, Safari: FAIL)
    • popups close hints but not asyncs: FAIL (Chrome: FAIL, Safari: FAIL)
    • hint, even with popup ancestor, closes with first popup: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eac81f2b151f [wpt PR 33801] - Add actual support for popup=hint and popup=async, a=testonly https://hg.mozilla.org/integration/autoland/rev/664f3f5b4a1d [wpt PR 33801] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eac81f2b151f
https://hg.mozilla.org/mozilla-central/rev/664f3f5b4a1d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.