Closed Bug 1766541 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 33804 - [BlockFragmentation] Split null/max MinimalSpaceShortage representation

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33804 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33804
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[BlockFragmentation] Split null/max MinimalSpaceShortage representation

Previously we'd represent the "null" MinimalSpaceShortage as LayoutUnit::Max().

This causes us to be "confused" when we have a space-shortage which is
also LayoutUnit::Max(). This changes the representation to use
absl::optional\<LayoutUnit> for the algorithm parts, and internally
just a LayoutUnit (similar to the current layout-result), with "null"
being kIndefiniteSize.

Bug: 1314866
Change-Id: I27be96fddcc6dba260a3b7531483b168fd75e393

Reviewed-on: https://chromium-review.googlesource.com/3606583
WPT-Export-Revision: 62de0dbdb939c6a87e47f033e81a6e762933d249

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fd1cc526d6c [wpt PR 33804] - [BlockFragmentation] Split null/max MinimalSpaceShortage representation, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.