1766592 - The "Focus Promo" message is wrongly displayed on the fist opened tab after it was dismissed

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Notes]:

• This seems to be a tab preloading issue because the experiment message appears blocked on the "ASRouter" page right after it was dismissed.

[Affected versions]:

• Firefox Beta 100.0 - Build ID: 20220425210429

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.2
• Linux Mint 20.2 x64

[Prerequisites]:

• Have a Firefox en-* locale build installed.
• Have the "nimbus.debug" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Navigate to the "about:studies?optin_slug=firefox-focus-pbm-fx100&optin_branch=treatment&optin_collection=nimbus-preview" URL.
3. Open a new "Private Window" and click the "X" button from the right part of the "Focus Promo" message.
4. Open a new tab in the same "Private Window" and observe the behavior.

[Expected result]:

• The "Focus Promo" message is NOT displayed.

[Actual result]:

• The "Focus Promo" message is displayed.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

@mcoman This is preloading of a tab issue ( not replicable with browser.newtab.preload pref as false) and require code change to remove promo containers on preloaded tab by one of the option below

a) Check if message shown is blocked and remove promo container, similar to how capturing message impression are handled
https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#195

https://searchfox.org/mozilla-central/rev/86c98c486f03b598d0f80356b69163fd400ec8aa/browser/components/newtab/lib/ASRouter.jsm#1077

b) Refresh page on dismiss click , this option though easier to implement might not be desirable user experience

I have updated FX100 Focus promo experiment QA ticket with this as known issue so that data analysis can account for this in telemetry while computing overall dismiss rate Thanks

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed

Comment 3

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

This fix is needed with increased frequency cap as default in Fx101 about:privatebrowsing

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8685a39eb807
[Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8685a39eb807

Comment 6

[Meg Viar [:mviar]]

Attachment: Bug 1766592 - BETA [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed

Comment 7

[Meg Viar [:mviar]]

Comment on attachment 9275250 [details]
Bug 1766592 - BETA [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed

Beta/Release Uplift Approval Request

• User impact if declined: Users who dismiss the Focus promo in a PBM tab will see it again when they open another PBM tab because that tab was prerendered,.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open a private browsing mode tab with a fresh user profile (you should see a Firefox Focus promo on page)

• Click the X to dismiss the promo
• Open a new private browsing mode tab (you should not see a Firefox Focus promo in the new tab)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change only affects the visibility of PBM promos.
• String changes made/needed: n/a
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275250 [details]
Bug 1766592 - BETA [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed

Approved for 101.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fd405fbd46c6

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified that this issue is no longer reproducible using the latest Firefox Nightly 102.0a1 (Build ID: 20220508190220) and Firefox Beta 101.0b4 (Build ID: 20220508185621) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.04 x64.

• The “Focus Promo” message is no longer displayed in a new private tab after it was dismissed.