1766669 - When closing last tabs of two windows, they are restored on restart

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Antonin LOUBIERE]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

1. Enable session restore (open previous windows and tabs settings)
2. Open 2 windows with one tab each (tab 1 in window 1 and tab 2 in window 2)
3. Wait a little
4. Close the two tabs quite rapidly (for example, with the shortcut ctrl+w) (tab 2 first and then tab 1 for example)
5. Restart Firefox

Actual results:

The two windows are restored with their respective tabs (window 1 with tab 1 and window 2 with tab 2).

Expected results:

The tabs have been closed so they should not be restored. Only one window with the home tab should be restored. Reopen closed tab should restore the tab of the last closed window (in this case tab 1). Ctrl+Shift+N (restore last window) should restore the second window (window 2) with its tab (tab 2).

See bug 490136, and bug 1732366.

Comment 1

[Antonin LOUBIERE]

Attachment: Bug 1766669 - When closing last tabs of multiple windows, don't restore them on restart. r=Gijs

After closing last tabs of multiple windows, only if we don't use session restore we restore them.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f034002d8a0
When closing last tabs of multiple windows, don't restore them on restart. r=Gijs

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures related to TestSessionStoreEnabledAllWindows.test_close_tabs
Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-ERROR | browser/components/sessionstore/test/marionette/test_restore_windows_after_close_last_tabs.py TestSessionStoreEnabledAllWindows.test_close_tabs | OSError: Process still running 70.0s after quit request

Comment 5

[Antonin LOUBIERE]

Ok, thank you, I will investigate.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8822bdecf78
When closing last tabs of multiple windows, don't restore them on restart. r=Gijs

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e8822bdecf78

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue following STR from comment 0 with Firefox 101.0a1 (20220427213431) on Windows 10x64.
The issue is verified fixed with Firefox 104.0b4 (20220731190208) on Windows 10x64, macOS 11 and Ubuntu 21. The closed windows are not opened after restart when following the STR from comment 0 with session restore enabled.