1766716 - pipeTo with an aborted signal does not abort in a certain case

Status: RESOLVED FIXED

(Core :: DOM: Streams, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

let a = new AbortController()
a.abort()
let b = new File(['ó ¬—a'], 'a', {})
let c = new WritableStream()
await b.stream().tee()[0].pipeTo(c, { 'signal': a.signal })

This rejects right away on Chrome but never rejects on Gecko.

Comment 1

[Tom S]

The problem seems to be related to the promise returned from ReadableStreamCancel never resolving.

Comment 2

[Tom S]

I think I've got it. For a tee'd stream to resolve both streams need to be canceled. https://streams.spec.whatwg.org/#abstract-opdef-readablestreamdefaulttee Step 14.3.3.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

So this can be resolved as invalid?

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Check the reference implementation behavior and file a spec bug if it also rejects right away as Chrome does?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

The reference test has no File.stream 😬

I feel like it's the File method that is problematic here (either in Gecko or Blink), but I'm not anywhere yet to pinpoint.

Edit 1: Okay, comment #2 was right, canceling another branch does resolve it.

Edit 2: I successfully reproduced this with user-defined readable byte stream. The reference implementation shows the same behavior with Gecko, so this is Blink issue. I'll add a WPT test soon.

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1766716 - Add a test for teed readable byte stream + pipeTo r=evilpie,mgaudet

This passes on Gecko and the reference implementation but not on Chrome.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aa40d4543da
Add a test for teed readable byte stream + pipeTo r=mgaudet

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34056 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4aa40d4543da