Closed Bug 1766808 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33839 - Fix |FramePainter| to reset |DisplayItemFragment|

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33839 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33839
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Fix |FramePainter| to reset |DisplayItemFragment|

In-process IFRAME can create NG --> legacy --> NG paint calls.

The fragment ID is currently used for 3 purposes in NG:

  1. NG block fragmentation.
  2. NG inline box fragmentation (line wrapping.)
  3. NG line box.

When an in-process IFRAME in a non-culled inline box has self-
painting layer inline boxes:

  1. The outer inline box sets the fragment ID.
  2. The IFRAME is painted by a legacy |FramePainter|.
  3. It calls |NGInlineBoxPainter| for the self-painting layer
    inline boxes.

Then at 3, the fragment ID has incorrect value. This patch
fixes it to 0.

Bug: 1320310
Change-Id: I2ebed9503d9e048a24ed3cb68909dcef6f508ec2
Reviewed-on: https://chromium-review.googlesource.com/3610681
WPT-Export-Revision: 3d245088ed824e3b31d632ac96cfe181217f84ec

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87c2ec303802
[wpt PR 33839] - Fix |FramePainter| to reset |DisplayItemFragment|, a=testonly

https://hg.mozilla.org/mozilla-central/rev/87c2ec303802

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.