Closed Bug 1766830 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33842 - Make sure removed/stopped transceivers are reflected as such in JS.

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33842 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33842
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:

Make sure removed/stopped transceivers are reflected as such in JS.

RTCRtpTransceiver::UpdateMembers() makes sure transceivers are
up-to-date with the lower layers. But when fully stopped transceivers
are removed their states are never surfaced. While we correctly removed
these transceivers, the JS app could still keep references to these
objects and upon inspection they look as if they have not been stopped.

This CL fixes issues relating to stop by...

  • Making sure the states reflects being stopped using
    RTCRtpTransceiver::OnTransceiverStopped().
  • Making sure "direction" is surfaced if when becoming kStopped.

This CL also gets rid of boolean stopped since this has been removed
from the spec (it's equivalent to direction == "stopped") and updates
some old WPTs that to expect currentDirection to be "stopped" when
stopped rather than null and that stopped transceivers are removed from
getTransceivers().

Bug: 1319911, 1319913
Change-Id: I437e15db3291ffe9121b5e8c6afa02901fd68663

Reviewed-on: https://chromium-review.googlesource.com/3609972
WPT-Export-Revision: 28c48a51b61da66c4d0eedb2a3832f6a9f1871a3

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests and 38 subtests

Status Summary

Firefox

OK : 2
PASS : 69
FAIL : 13

Chrome

OK : 1
PASS : 74
FAIL : 8
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webrtc/RTCPeerConnection-transceivers.https.html [wpt.fyi]
    • addTransceiver(track, init): initialize sendEncodings[0].active to false: FAIL (Chrome: PASS)
    • Closing the PC stops the transceivers: FAIL (Chrome: FAIL)
  • /webrtc/RTCRtpTransceiver.https.html [wpt.fyi]
    • checkCurrentDirection: FAIL (Chrome: FAIL)
    • checkAddTransceiverThenAddTrackPairs: FAIL (Chrome: PASS)
    • checkStop: FAIL (Chrome: FAIL)
    • checkStopAfterCreateOffer: FAIL (Chrome: PASS)
    • checkStopAfterSetLocalOffer: FAIL (Chrome: PASS)
    • checkStopAfterSetRemoteOffer: FAIL (Chrome: PASS)
    • checkStopAfterCreateAnswer: FAIL (Chrome: PASS)
    • checkStopAfterSetLocalAnswer: FAIL (Chrome: PASS)
    • checkLocalRollback: FAIL (Chrome: PASS)
    • checkRemoteRollback: FAIL (Chrome: FAIL)
    • checkMsectionReuse: FAIL (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c0aed8393e0 [wpt PR 33842] - Make sure removed/stopped transceivers are reflected as such in JS., a=testonly https://hg.mozilla.org/integration/autoland/rev/803a1345e834 [wpt PR 33842] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1c0aed8393e0
https://hg.mozilla.org/mozilla-central/rev/803a1345e834

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.