1766844 - Avoid unnecessary notify_one calls in internal thread pool

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

This will make our condition variable behave more like it did before the XPCOM thread pool refactoring last year and might be a good workaround for the glibc bug in bug 1765970.

I can't repro the test timeout issue locally or in CI with this change so it's worth a try.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1766844 - Avoid unnecessary notify_one calls in internal thread pool. r?jonco!

Don't call notify_one if we just finished a task on a helper thread, because we can
simply run the next task on this same thread.

This way we use the condition variable more like we did before the thread pool
refactoring, so it might help us work around the glibc bug in bug 1765970.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa9873b86291
Avoid unnecessary notify_one calls in internal thread pool. r=jonco

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aa9873b86291