1766869 - Deduplicate selected snapshots based on query parameters and titles

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P3)

Description

[Mark Banner (:standard8)]

If snapshots have the same main url (without the query) and the same title, we want to deduplicate the returned snapshots. In this case, we prefer snapshots with no query first, then the best snapshot based on score or recency.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1766869 - Deduplicate selected snapshots based on query parameters and titles. r?mak,Mossop

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1766869 - Deduplicate relevancy based selected snapshots based on query parameters and titles. r?mak,Mossop

Depends on D144975

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02fe53ee07bc
Deduplicate selected snapshots based on query parameters and titles. r=mossop
https://hg.mozilla.org/integration/autoland/rev/bf44638c5748
Deduplicate relevancy based selected snapshots based on query parameters and titles. r=mossop

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_preventive_maintenance.js

Backout link

Push with failures

Failure log

Failure line(s): TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/maintenance/test_preventive_maintenance.js | test_preventive_maintenance - [test_preventive_maintenance : 2111] 0 == 2

Comment 5

[Mark Banner (:standard8)]

Sorry, I forgot to fully check the impact of the PlacesTestUtils changes.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81fe2edb9886
Deduplicate selected snapshots based on query parameters and titles. r=mossop
https://hg.mozilla.org/integration/autoland/rev/dfc3eca16c52
Deduplicate relevancy based selected snapshots based on query parameters and titles. r=mossop

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/81fe2edb9886
https://hg.mozilla.org/mozilla-central/rev/dfc3eca16c52