1766975 - Add keyboard shortcut to focus the filter input

Status: RESOLVED FIXED

(DevTools :: Style Editor, enhancement)

Description

[Nicolas Chevobbe [:nchevobbe]]

In other panels, we often have a global keyboard shortcut (most of the time, Ctrl|Cmd+F) that focuses a filter input we might have there (e.g. in inspetcor, console, netmonitor).
It would be nice to have similar behavior in the style editor as well.
The only thing we need to take care of is that when the focus is in a stylesheet (so in a code mirror instance), Ctrl|Cmd+F will trigger a in-file search, which we still want to have.

I think it would be reasonable to use the same shortcut we have in the debugger to search for a given file (Ctrl|Cmd+P), even though in the debugger case, it opens the command palette.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1766975 - [devtools] Add keyboard shortcut to focus StyleEditor filter input. r=jdescottes.

We using Ctrl|Cmd+P as Ctrl|Cmd+F is used for a in-file search in
the CodeMirror instance.
We're tesing the keyboard shortcut in browser_style_editor_filter.js
by using it instead of manually calling input.focus and clearing it
programatically.

Depends on D144930

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d915f68a1f13
[devtools] Add keyboard shortcut to focus StyleEditor filter input. r=jdescottes.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d915f68a1f13