1767066 - Remove More from Mozilla "advanced" pane

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Since we've decided not to drive it forward.

Comment 1

[Meg Viar [:mviar]]

Scope of the cleanup includes removing:

• Advanced QR code SVG and references
• Styles for advanced template from preferences.css
• Strings for advanced template from moreFromMozilla.ftl
• Logic and references related to advanced template from moreFromMozilla.js
• Advanced template from moreFromMozilla.inc.xhtml
• Tests for advanced template from tests/browser_moreFromMozilla.js

Comment 2

[Vtay]

bye bye advanced pane

Comment 3

[Meg Viar [:mviar]]

It was ahead of its time.

Comment 4

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1767066 - Remove More from Mozilla "advanced" pane

Comment 5

[Meg Viar [:mviar]]

@pdahiya - is there any reason to hold onto logic around default vs simple template and setting experiment params now that simple is the default? They only seem useful if we anticipate additional experimentation with this surface.

Comment 6

[Meg Viar [:mviar]]

^

Comment 7

[Punam Dahiya [:pdahiya]]

(In reply to Meg Viar from comment #5)

@pdahiya - is there any reason to hold onto logic around default vs simple template and setting experiment params now that simple is the default? They only seem useful if we anticipate additional experimentation with this surface.

@mviar there is a JIRA ticket in backlog that wants MfM to be updated with new products and look and feel, so possible we will reuse templates and experiment params. I will recommend filing a follow up bug for template and experiment params cleanup. Thanks

Comment 8

[Hanna Alemu [:hanna_a]]

(In reply to Punam Dahiya [:pdahiya] from comment #7)

(In reply to Meg Viar from comment #5)

@pdahiya - is there any reason to hold onto logic around default vs simple template and setting experiment params now that simple is the default? They only seem useful if we anticipate additional experimentation with this surface.

@mviar there is a JIRA ticket in backlog that wants MfM to be updated with new products and look and feel, so possible we will reuse templates and experiment params. I will recommend filing a follow up bug for template and experiment params cleanup. Thanks

Sounds good, I can add those back in. Thanks!

Comment 9

[Meg Viar [:mviar]]

@hanna I think that part is good to go as you have it. Here's bug 1775260 for the future if/when we wrap up experimentation with this surface.

Comment 10

[Hanna Alemu [:hanna_a]]

Attachment: WIP: Bug 1767066 - Remove More from Mozilla "advanced" pane: removed string

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0913ab5fe7fc
Remove More from Mozilla "advanced" pane r=mviar,fluent-reviewers,preferences-reviewers,pdahiya,Gijs

Comment 12

[Marian-Vasile Laza]

Backed out changeset 0913ab5fe7fc (Bug 1767066) for causing bustages on img-mobile.svg.
Backout link
Push with failures
Failure Log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d76b56ced4db
Remove More from Mozilla "advanced" pane r=mviar,fluent-reviewers,preferences-reviewers,pdahiya,Gijs

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d76b56ced4db

Comment 15

[Hanna Alemu [:hanna_a]]

(In reply to Meg Viar from comment #9)

@hanna I think that part is good to go as you have it. Here's bug 1775260 for the future if/when we wrap up experimentation with this surface.

Comment 16

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this task using the latest Firefox Nightly 104.0a1 (Build ID: 20220628191450) and Firefox Beta 103.0b2 (Build ID: 20220628190840) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

• The “More From Mozilla” section is correctly displayed, and there is no difference after the code clean-up.