1767105 - [wpt-sync] Sync PR 33882 - [BroadcastChannel] Fix issues with the data URL worker tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33882 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33882
Details from upstream follow.

Andrew Williams <[e-mail]> wrote:

[BroadcastChannel] Fix issues with the data URL worker tests

Looks like there were a few issues with the data URL worker
BroadcastChannel tests that I added recently. Specifically:

• Since I used AddEventListener on the SharedWorker port, I needed
  to explicitly call start() on them or the test wouldn't be able
  to pass.

• The way I was constructing the data URLs meant that comments added
  into the worker code broke the test in at least Firefox. The
  data URL contents now get properly percent-encoded.

• The SharedWorker connect handler code needed to be refactored so
  that the port object could actually be postMessage'd to
  successfully.

Bug: 1058759
Change-Id: I88ef36aba10a7e53eac913057910b2ad22118e35
Reviewed-on: https://chromium-review.googlesource.com/3615056
WPT-Export-Revision: a8530be15189a8baadf42cfd4de59665eb1da23e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 33882 applied with additional changes from upstream: bd235e3733de6845ba1d0ffa64464a6e9370fee4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=53bf04d99bd5d12d24aed4ed6b25ba0daecf8331

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 4

Chrome

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
PASS: 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29d4245a5e9e
[wpt PR 33882] - [BroadcastChannel] Fix issues with the data URL worker tests, a=testonly

Comment 5

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/29d4245a5e9e