Closed Bug 1767281 Opened 3 years ago Closed 2 years ago

0.1 - 0.06% installer size / installer size (OSX) regression on Wed April 27 2022

Categories

(Core :: Preferences: Backend, defect)

Product:
Core
Component:
Preferences: Backend
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1765734
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- unaffected
firefox101 --- wontfix
firefox102 --- wontfix

People

(Reporter: aesanu, Unassigned)

References

(Regression)

Details

(Keywords: perf-alert, regression)

Perfherder has detected a build_metrics performance regression from push 6e78cd06efbcbbf4785fa112cf80dfc0ff499e68. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
0.10% installer size osx-shippable instrumented 118,990,296.00 -> 119,106,171.25
0.06% installer size osx-shippable instrumented 118,996,061.12 -> 119,063,364.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(tom)

Are we certain this is my patch? I didn't do anything OS-specific, so while there might be differences in platform installer details, I would expect any change to really affect all installers. Additionally, I didn't do anything unusual with my patchset - it was large, but it only modified and added code. If I was going to guess it may be because I added a conditional to the static pref template which would translate into that new conditional being duplicated for every static pref we have...

That's not ideal, but for now it's part of the assertions we need to make while we roll out the preference sanitization. In the future we may be able to shrink this by tweaking the conditional...

Flags: needinfo?(tom)
Has Regression Range: --- → yes

Set release status flags based on info from the regressing bug 1752332

status-firefox100: --- → unaffected
status-firefox101: --- → affected
status-firefox102: --- → affected
status-firefox-esr91: --- → unaffected

Looking at the graph, this is a regression from bug 1758780 AFAICT (which would make a lot more sense). That said, it's also probably inactionable.

Flags: needinfo?(mh+mozilla)
Regressed by: 1758780
No longer regressed by: 1752332
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → DUPLICATE

Note: we don't care about "instrumented" builds installer size. I don't know why we track regressions on those.

You need to log in before you can comment on or make changes to this bug.