1767357 - Enable Animation.timeline setter in release channels

Status: RESOLVED FIXED

(Core :: DOM: Animation, task)

Description

[Brian Birtles (:birtles)]

I notice that WebKit just turned this on by default:

https://trac.webkit.org/changeset/291868/webkit/

Whereas we have it disabled everywhere except Nightly:

https://searchfox.org/mozilla-central/rev/87ecd21d3ca517f8d90e49b32bf042a754ed8f18/dom/webidl/Animation.webidl#26-32

I think we were waiting to see if the algorithm for that setter changed significantly as part of the scroll timelines work. But perhaps it's safe to ship now?

Boris, what do you think?

Comment 1

[Boris Chiou [:boris]]

I think it's fine to ship this. We are not planning to implement JS support for scroll-linked animations in this half year, so enabling this API on release and beta channels is OK to me. (So the setter is only for document timeline and null timeline).

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1767357 - Enable Animation.timeline setter in release channels.

Basically, this patch reverts https://phabricator.services.mozilla.com/D63432.
Webkit just turns this on by default [1], so it's worth to enable this
in our release channels.

[1] https://trac.webkit.org/changeset/291868/webkit/

Comment 3

[Boris Chiou [:boris]]

intent-to-ship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/eVCC6hqgaeE

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de3ae6e428b5
Enable Animation.timeline setter in release channels. r=birtles,emilio

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/de3ae6e428b5