1767386 - WARNING: '!document', file /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:562

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

WARNING: '!document', file /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:562
WARNING: '!computedDOMStyle', file /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:511
WARNING: CSSEditUtils::GetComputedCSSInlinePropertyBase() failed: file /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:961
WARNING: CSSEditUtils::GetCSSEquivalentToHTMLInlineStyleSetInternal() failed: file /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:1011

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1767386 - part 1: Make some `CSSEditUtils` methods using `GetCSSEquivalentToHTMLInlineStyleSetInternal` return error with `Result` r=m_kato!

CSSEditUtils::GetCSSEquivalentToHTMLInlineStyleSetInternal may return error
which is unexpected. And the methods changed by this patch may cause destroying
editor if and only if they treat computed style. Therefore, they should be
non-static members and they should return error to make each caller avoid the
unexpected cases if necessary.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1767386 - part 2: Make `HTMLEditor::RemoveInlinePropertyInternal` stop setting/removing style of an element if it's removed by `RemoveStyleInside` r=m_kato!

CSSEditUtils will refer the composed document of the element to compute the
style of it. However, it'll fail if RemoveStyleInside has already removed
the element from the DOM tree. Therefore, RemoveInlinePropertyInternal
should stop handling the element immediately after calling RemoveStyleInside
if the element is removed.

Depends on D145303

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55a42e3b6193
part 1: Make some `CSSEditUtils` methods using `GetCSSEquivalentToHTMLInlineStyleSetInternal` return error with `Result` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d73edeb576a4
part 2: Make `HTMLEditor::RemoveInlinePropertyInternal` stop setting/removing style of an element if it's removed by `RemoveStyleInside` r=m_kato

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/55a42e3b6193
https://hg.mozilla.org/mozilla-central/rev/d73edeb576a4