Closed Bug 1767540 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33919 - Add stylability to the ::backdrop element for popup

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33919
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Add stylability to the ::backdrop element for popup

The ::backdrop element was always there, but this CL makes it
fixed position, full-viewport, so it can be styled/visible. Tests are
also added for stacking and appearance.

See:
https://github.com/openui/open-ui/issues/519

Bug: 1307772
Change-Id: I2527aef33f89b140950d92302a7aefac0b6efc03
Reviewed-on: https://chromium-review.googlesource.com/3621791
WPT-Export-Revision: ebd0ae734aeca75f4f4bacc8ba3f73f6301f517d

PR 33919 applied with additional changes from upstream: 27622a853844ef5d16b1e53f83a2db5cb46d2596, 78c1949b7adf253f562a768bc1c7d0184727f559, df77a8e578af99c943f4f997b60ad9d0e753e57b, e018110fdcb47174942dec7042bbfb16a0e33039, 7e280cd5814a822cb05b7116eb2cbaf736af2803
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 18 subtests

Status Summary

Firefox

FAIL : 17
ERROR: 1

Chrome

OK : 1
PASS : 17
FAIL : 2

Safari

FAIL : 17
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-backdrop-appearance.tentative.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/popups/popup-light-dismiss.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Clicking outside a popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a popup does not close that popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus outside the popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a child popup shouldn't close either popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a parent popup should close child popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on anchor element (that isn't an invoking element) shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Dragging from an open popup outside an open popup should leave the popup open: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element should be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element that was not used to invoke the popup can still be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • Scrolling within a popup should not close the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving focus back to the anchor element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to the active trigger element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to an inactive trigger element should also not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopup(): FAIL (Chrome: PASS, Safari: FAIL)
    • Light dismiss of mixed popup types: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b4186e29f3f
[wpt PR 33919] - Add stylability to the ::backdrop element for popup, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c09837c7d9ae
[wpt PR 33919] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7b4186e29f3f
https://hg.mozilla.org/mozilla-central/rev/c09837c7d9ae

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.