Closed Bug 1767657 Opened 2 years ago Closed 3 months ago

Intermittent devtools/client/netmonitor/test/browser_net_telemetry_select_ws_frame.js | single tracking bug

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: jmaher, Assigned: jmaher, NeedInfo)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell unknown])

Attachments

(3 files)

Bug 1767657 - Disable browser_net_telemetry_select_ws_frame.js on mac/win opt. r=aryx
48 bytes, text/x-phabricator-request
Details | Review
Bug 1767657 - [devtools] Check if headers were successfully returned in websocket message component
48 bytes, text/x-phabricator-request
Details | Review
Bug 1767657 - [devtools] Fix checks in getResponse/RequestHeader utils to avoid throwing
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Filter on devtools-intermittent-singletrackingbug-triage

Severity: -- → S4

Update

There have been 34 failures within the last 7 days:

  • 17 failures on Windows 11 x64 22H2 WebRender Shippable opt
  • 6 failures on Windows 11 x64 22H2 WebRender opt
  • 6 failures on OS X 10.15 WebRender Shippable opt
  • 5 failures on OS X 10.15 WebRender opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=411031579&repo=autoland&lineNumber=3631

[task 2023-03-28T09:28:24.513Z] 09:28:24     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_telemetry_select_ws_frame.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-03-28T09:28:24.513Z] 09:28:24     INFO - finish() was called, cleaning up...
[task 2023-03-28T09:28:24.514Z] 09:28:24     INFO - Console message: [JavaScript Error: "TypeError: can't access property "length", responseHeaders.headers is undefined" {file: "resource://devtools/client/netmonitor/src/utils/request-utils.js" line: 509}]
[task 2023-03-28T09:28:24.514Z] 09:28:24     INFO - Buffered messages finished
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_telemetry_select_ws_frame.js | A promise chain failed to handle a rejection: can't access property "length", responseHeaders.headers is undefined - stack: getResponseHeader@resource://devtools/client/netmonitor/src/utils/request-utils.js:509:27
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - parsePayload@resource://devtools/client/netmonitor/src/components/messages/MessagePayload.js:142:41
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - async*updateMessagePayload/<@resource://devtools/client/netmonitor/src/components/messages/MessagePayload.js:107:66
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - Rejection date: Tue Mar 28 2023 09:28:24 GMT+0000 (Greenwich Mean Time) - false == true - {"filename":"resource://testing-common/PromiseTestUtils.sys.mjs","name":"assertNoUncaughtRejections","sourceId":562,"lineNumber":266,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest","sourceId":526,"lineNumber":675,"columnNumber":29,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"testScope/test_finish/<","sourceId":526,"lineNumber":1699,"columnNumber":25,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"run","sourceId":526,"lineNumber":1618,"columnNumber":9,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"run@chrome://mochikit/content/browser-test.js:1618:9\n","nativeSavedFrame":{}},"formattedStack":"async*testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1699:25\nrun@chrome://mochikit/content/browser-test.js:1618:9\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"nextTest@chrome://mochikit/content/browser-test.js:675:29\nasync*testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1699:25\nrun@chrome://mochikit/content/browser-test.js:1618:9\n","nativeSavedFrame":{}},"formattedStack":"assertNoUncaughtRejections@resource://testing-common/PromiseTestUtils.sys.mjs:266:14\nnextTest@chrome://mochikit/content/browser-test.js:675:29\nasync*testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1699:25\nrun@chrome://mochikit/content/browser-test.js:1618:9\n","nativeSavedFrame":{}}
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - Stack trace:
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - chrome://mochikit/content/browser-test.js:nextTest:675
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1699
[task 2023-03-28T09:28:24.517Z] 09:28:24     INFO - chrome://mochikit/content/browser-test.js:run:1618
[task 2023-03-28T09:28:24.806Z] 09:28:24     INFO - GECKO(1673) | MEMORY STAT | vsize 26351MB | residentFast 1914MB | heapAllocated 1145MB
[task 2023-03-28T09:28:24.806Z] 09:28:24     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_telemetry_select_ws_frame.js | took 2422ms

Jan, can you help us assign this to someone?
Thank you.

Flags: needinfo?(odvarko)
Whiteboard: [stockwell needswork:owner]

Bomsy, could you please help to diagnose this, thank you!

Flags: needinfo?(odvarko) → needinfo?(hmanilla)

Sure i'll take a look.

Assignee: nobody → jmaher
Status: NEW → ASSIGNED

The request which fails is actually triggered right after we close the toolbox and we fail to get request details

Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/624a6eaadcad
Disable browser_net_telemetry_select_ws_frame.js on mac/win opt. r=aryx,devtools-reviewers,jdescottes
Flags: needinfo?(hmanilla)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87b9f8022532
[devtools] Check if headers were successfully returned in websocket message component r=ochameau,devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a7d69e48affb
[devtools] Fix checks in getResponse/RequestHeader utils to avoid throwing r=devtools-reviewers,ochameau

https://hg.mozilla.org/mozilla-central/rev/87b9f8022532
https://hg.mozilla.org/mozilla-central/rev/a7d69e48affb

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: