1767800 - Refactor mozJSComponentLoader to split up script loading in preparation for loading ES6 modules

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Jon Coppeard (:jonco)]

Here are some patches to split up script loading in mozJSComponentLoader into a bunch of smaller methods. This will allow a module loader to call only the parts it needs.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 1: Fix error handling in mozJSComponentLoader::CreateLoaderGlobal r?mccr8

Minor fix. This didn't check for errors when defining functions. The patch gives
it a return value and returns null if this fails.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 1: Factor out method to load a JSScript from mozJSComponentLoader::ObjectForLocation r?mccr8

Depends on D145469

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 2: Factor out a method to determine if a URL is a real file from PrepareObjectForLocation r?mccr8

We won't call PrepareObjectForLocation when loading ES6 modules.

Depends on D145470

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 3: Factor out a method to get the source file location for a URI r?mccr8

Depends on D145471

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 4: Factor out a method to check whether a URL to load is trusted r?mccr8

Depends on D145472

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1767800 - Part 8: Add option to compile source to module stencil in mozJSComponentLoader r?yulia

This adds a flag to ComponentLoaderInfo to say whether it represents a module
and calls the appriate JS APIs based on this.

Depends on D145561

Comment 7

[Phabricator Automation]

Comment on attachment 9275162 [details]
Bug 1767800 - Part 8: Add option to compile source to module stencil in mozJSComponentLoader r?yulia

Revision D145562 was moved to bug 1432901. Setting attachment 9275162 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77f7ab7507a7
Part 1: Fix error handling in mozJSComponentLoader::CreateLoaderGlobal r=mccr8
https://hg.mozilla.org/integration/autoland/rev/47e2a79b5e9b
Part 2: Factor out method to load a JSScript from mozJSComponentLoader::ObjectForLocation r=mccr8
https://hg.mozilla.org/integration/autoland/rev/7efb637cd21a
Part 3: Factor out a method to determine if a URL is a real file from PrepareObjectForLocation r=mccr8
https://hg.mozilla.org/integration/autoland/rev/89007c9890d9
Part 4: Factor out a method to get the source file location for a URI r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a11c8dbd530e
Part 5: Factor out a method to check whether a URL to load is trusted r=mccr8

Comment 9

[Cristian Tuns]

Backed out for causing hazard failures on mozJSComponentLoader.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | hazards | unrooted '<returnvalue>' of type 'JSObject*' live across GC call at js/xpconnect/loader/mozJSComponentLoader.cpp:597

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c911f99fd05c
Part 1: Factor out method to load a JSScript from mozJSComponentLoader::ObjectForLocation r=mccr8
https://hg.mozilla.org/integration/autoland/rev/b9fb752be4a1
Part 2: Factor out a method to determine if a URL is a real file from PrepareObjectForLocation r=mccr8
https://hg.mozilla.org/integration/autoland/rev/4b22d24b5c4e
Part 3: Factor out a method to get the source file location for a URI r=mccr8
https://hg.mozilla.org/integration/autoland/rev/f92a19fe87cc
Part 4: Factor out a method to check whether a URL to load is trusted r=mccr8

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c911f99fd05c
https://hg.mozilla.org/mozilla-central/rev/b9fb752be4a1
https://hg.mozilla.org/mozilla-central/rev/4b22d24b5c4e
https://hg.mozilla.org/mozilla-central/rev/f92a19fe87cc