1767869 - Stop using old EnigmailSqliteDb code

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert (:KaiE:)]

The OpenPGP code still contains references to the old Enigmail database storage, which used file EnigmailSqliteDb.

We still open and initialize that database. But I've checked, we don't have any active code that can reach the calls that use it.

It's time to remove that old code. And I'd also like to remove all disabled/commented code that's related. If we really ever need that code again, we can use it as inspiration and re-import parts of it.

The trigger for this:

Today Christian reported a strange failure, OpenPGP not working. We tried to open that file as part of our init code, but the core resource://gre/modules/Sqlite.jsm reported NS_ERROR_FILE_CORRUPTED. The file was from 2017, so maybe the core can no longer open files in an old storage format?

I don't want to risk breakage to files that we no longer need, so it's easiest to stop using that code.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1767869 - Remove EnigmailSqliteDb and related unused code. r=mkmelin

Comment 2

[Magnus Melin [:mkmelin]]

Fixed some linting before pushing

Comment 3

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/1f61a0ae1fb5a76868da77c96e36ce1648054289 (dunno why the bot didn't close)

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 9275077 [details]
Bug 1767869 - Remove EnigmailSqliteDb and related unused code. r=mkmelin

I'd like to have beta testing of this code. This one is for code consistency and avoid potential merge conflicts. Only removing unused code.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9275077 [details]
Bug 1767869 - Remove EnigmailSqliteDb and related unused code. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/01e47a2084ad