1767888 - Rename BackstagePass to (something like) SystemGlobal

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Kris Maglione [:kmag]]

The BackstagePass name is fairly cryptic, and particularly in the place it shows up most (leak reports), it doesn't convey anything to most users. At this point, there's usually only one of them to hold system JSMs, non-JSM JS components (which are mostly gone at this point), and some other random system objects. We should probably just call it SystemGlobal.

Comment 1

[Andrew McCreight [:mccr8]]

Personally, I think I re-learned and forgot what BackstagePass was like 4 or 5 times until it finally stuck, and figuring out it each time meant digging around for references to it in the code until I realized that, ah yes this is a global.

Comment 2

[Bobby Holley (:bholley)]

+1 to SystemGlobal.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1767888 - Rename BackstagePass to SystemGlobal. r?mccr8!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dca875891793
Rename BackstagePass to SystemGlobal. r=mccr8,credential-management-reviewers,peterv,dimi

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/dca875891793