1767899 - Use EventTargetCapability to protect members in TrackBuffersManager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

This follows on from bug 1767897. Assuming we have something like EventTargetAsserter, we can clarify and better enforce thread usage in TrackBuffersManager.

Bug 1724106 is a good example of why we'd want to do this. TrackBuffersManager is complicated and it would not hurt to have better documented threading expectations or further guard rails.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1767899 - Guard some members that expect to be accessed on event target in TrackBuffersManager.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bd60f359de2
Guard some members that expect to be accessed on event target in TrackBuffersManager. r=media-playback-reviewers,alwu

Comment 3

[Marian-Vasile Laza]

Backed out changeset 9bd60f359de2 (Bug 1767899) for causing build bustages on EventTargetCapability.h.
Backout link
Push with failures
Failure Log

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Looks like I'm missing an explicit keyword for some of the code that landed in bug 1767897 and is now being used. I'm currently inactive, so if anyone else wants to fix that up, feel free. Otherwise I'll hold NI in case I get time to fix this up.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bryce, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1767899 - add `explicit` on EventTargetCapability ctor to fix build error.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dfc0a554224
Guard some members that expect to be accessed on event target in TrackBuffersManager. r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/ee981764696b
add `explicit` on EventTargetCapability ctor to fix build error. r=media-playback-reviewers,padenot

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0dfc0a554224
https://hg.mozilla.org/mozilla-central/rev/ee981764696b