1767924 - browsingContext.navigate shouldn't navigate with the same hash in URL

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Alexandra Borovova [:Sasha]]

Follow up of bug 1766217

browsingContext.navigate shouldn't navigate when called with the same hash in URL (e.g. from http://some.url#some-hash to http://some.url#some-hash)
In the scope of the bug would be also good to add new wdspec tests to check if same URL without hash navigates and with the same hash doesn't.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1767924 - Add requireBeforeUnload flag to Webdriver BiDi Navigate.

Comment 2

[Phabricator Automation]

Comment on attachment 9275251 [details]
Bug 1767924 - Add requireBeforeUnload flag to Webdriver BiDi Navigate.

Revision D145617 was moved to bug 1766217. Setting attachment 9275251 [details] to obsolete.

Comment 3

[Julian Descottes [:jdescottes]]

Some clarifications: in general calling navigate with the same URL should "reload", except when this URL has a hash.

Navigating from http://some.url to http://some.url should navigate (ie reload).
Navigating from http://some.url#some-hash to http://some.url#some-hash should not navigate.
(you can roughly experiment by using the URL bar to verify this behavior)

This bug is about handling the second use case, otherwise after bug 1766217, the progress listener will never resolve.
And it is worth adding a test for the first use case, to verify that we actually reload.

Can we update the bug title and description accordingly?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1767924 - Handle navigation between urls with the same hashes.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1767924 - Add wdspec test for browsingContext.navigate between urls with same hashes.

Depends on D146918

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c53a740d8e8
Handle navigation between urls with the same hashes. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ad78b7686e01
Add wdspec test for browsingContext.navigate between urls with same hashes. r=webdriver-reviewers,whimboo

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34160 for changes under testing/web-platform/tests

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7c53a740d8e8
https://hg.mozilla.org/mozilla-central/rev/ad78b7686e01

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot