Closed Bug 1767924 Opened 2 months ago Closed 1 month ago

browsingContext.navigate shouldn't navigate with the same hash in URL

Categories

(Remote Protocol :: WebDriver BiDi, defect, P3)

defect
Points:
2

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

(Blocks 1 open bug)

Details

(Whiteboard: [bidi-m3-mvp], [wptsync upstream])

Attachments

(2 files, 1 obsolete file)

Follow up of bug 1766217

browsingContext.navigate shouldn't navigate when called with the same hash in URL (e.g. from http://some.url#some-hash to http://some.url#some-hash)
In the scope of the bug would be also good to add new wdspec tests to check if same URL without hash navigates and with the same hash doesn't.

Blocks: 1730641
Whiteboard: [webdriver:backlog]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Attachment #9275251 - Attachment description: WIP: Bug 1767924 - Add requireBeforeUnload flag to Webdriver BiDi Navigate. → Bug 1767924 - Add requireBeforeUnload flag to Webdriver BiDi Navigate.

Comment on attachment 9275251 [details]
Bug 1767924 - Add requireBeforeUnload flag to Webdriver BiDi Navigate.

Revision D145617 was moved to bug 1766217. Setting attachment 9275251 [details] to obsolete.

Attachment #9275251 - Attachment is obsolete: true
Status: ASSIGNED → NEW

Some clarifications: in general calling navigate with the same URL should "reload", except when this URL has a hash.

Navigating from http://some.url to http://some.url should navigate (ie reload).
Navigating from http://some.url#some-hash to http://some.url#some-hash should not navigate.
(you can roughly experiment by using the URL bar to verify this behavior)

This bug is about handling the second use case, otherwise after bug 1766217, the progress listener will never resolve.
And it is worth adding a test for the first use case, to verify that we actually reload.

Can we update the bug title and description accordingly?

Flags: needinfo?(aborovova)
Assignee: aborovova → nobody
Flags: needinfo?(aborovova)
Summary: browsingContext.navigate shouldn't trigger reload with the same URL → browsingContext.navigate shouldn't navigate with the same hash in URL
Points: --- → 2
Depends on: 1763127
Priority: -- → P3
Whiteboard: [webdriver:backlog] → [bidi-m3-mvp]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Severity: -- → S3
Flags: needinfo?(hskupin)
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Attachment #9277497 - Attachment description: WIP: Bug 1767924 - Handle navigation between urls with the same hashes. → Bug 1767924 - Handle navigation between urls with the same hashes.
Attachment #9277498 - Attachment description: WIP: Bug 1767924 - Add wdspec test for browsingContext.navigate between urls with same hashes. → Bug 1767924 - Add wdspec test for browsingContext.navigate between urls with same hashes.
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c53a740d8e8
Handle navigation between urls with the same hashes. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ad78b7686e01
Add wdspec test for browsingContext.navigate between urls with same hashes. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34160 for changes under testing/web-platform/tests
Whiteboard: [bidi-m3-mvp] → [bidi-m3-mvp], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.