1767944 - Custom drag image mispositioned when page is zoomed

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Kestrel]

Attachment: Horse custom cursor image should be over dark green square.

STR:

1. Visit https://react-dnd.github.io/react-dnd/examples/tutorial.
2. Zoom page to 133%.
3. Drag the chess piece.

Cursor image is located some distance above and to the left of the cursor instead of directly over it.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8978bed93cff158ff68e6ceca7e4530e2f520951&tochange=85fb6ffa2887b21084c20349e999b1ec46db1993

Regressed by Bug 1753836.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1753836, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

That's not a cursor, but sure, can look, thanks for filing!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1767944 - Fix drag image coordinates after bug 1753836. r=tnikkel,mstange

The existing code was relying on the drag event coordinates being
already unscaled by the zoom, which bug 1753836 fixed.

This simplifies the relevant code and fixes the bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cef7cb4d90ab
Fix drag image coordinates after bug 1753836. r=tnikkel

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cef7cb4d90ab

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9275185 [details]
Bug 1767944 - Fix drag image coordinates after bug 1753836. r=tnikkel,mstange

Beta/Release Uplift Approval Request

• User impact if declined: Mispositioned drag images with zoomed pages.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple zoom-specific coordinate space fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275185 [details]
Bug 1767944 - Fix drag image coordinates after bug 1753836. r=tnikkel,mstange

Approved for 101.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/179b6f9df289

Comment 10

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in release 100 using Windows 10.
Verified - Fixed in latest Nightly 102.0a1 (2022-05-10) and Beta 101.0b5 (build id: 20220509162644) using Windows 10, macOS 12 and Ubuntu 20.