Remove DateTimeFormat::TryCreateFromSkeleton in favour of TryCreateFromComponents
Categories
(Core :: Internationalization, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(4 files)
TryCreateFromSkeleton is only used by fluent-ffi, where we translate a components bag structure to a skeleton string. Instead of doing that, we can simply pass the components bag to C++ and translate it into DateTimeFormat::ComponentsBag.
|
Assignee | |
Comment 1•2 years ago
|
||
All callers were passing Nothing() for the hour-cycle override parameter, so
we might as well remove the parameter from the public API surface.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Instead of creating a skeleton from the components bag on the Rust side,
directly pass the Rust components bag and translate it into the C++
components bag after crossing the FFI boundary.
Depends on D145580
|
|
Assignee | |
Comment 3•2 years ago
|
||
There aren't any callers left for TryCreateFromSkeleton() after part 2.
Depends on D145581
|
|
Assignee | |
Comment 4•2 years ago
|
||
TryCreateFromSkeleton() is only called internally in DateTimeFormat, so we
can make it a private method to reduce the API surface.
Depends on D145582
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/edfd6f83323a Part 1: Remove hour-cycle override from TryCreateFromSkeleton public API. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/fcb9681fb43c Part 2: Switch fluent-ffi to use TryCreateFromComponents. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/c01bc143e756 Part 3: Remove no longer used TryCreateFromSkeleton() method. r=platform-i18n-reviewers,dminor https://hg.mozilla.org/integration/autoland/rev/188e42a20c32 Part 4: Make TryCreateFromSkeleton a private method. r=platform-i18n-reviewers,dminor
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/edfd6f83323a
https://hg.mozilla.org/mozilla-central/rev/fcb9681fb43c
https://hg.mozilla.org/mozilla-central/rev/c01bc143e756
https://hg.mozilla.org/mozilla-central/rev/188e42a20c32
Description
•