Closed
Bug 1768054
Opened 2 years ago
Closed 2 years ago
Verify text bounds are correct for embedded characters
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
102 Branch
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: morgan, Assigned: morgan)
References
Details
Attachments
(1 file)
In this patch Jamie flagged that we may need to set aDescendToEnd to true to correctly compute bounds for embedded characters. We should verify this is needed.
|
||
Comment 1•2 years ago
|
||
(In reply to Morgan Reschenberg [:morgan] from comment #0)
we may need to set
aIncludeOriginto true to correctly compute bounds for embedded characters.
I meant set aDescendToEnd to true when calling ToTextLeafPoint. I suspect this was just a typo in your comment, but thought I'd clarify just in case. :)
|
Assignee | |
Comment 2•2 years ago
|
||
yep updated, thanks!
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D144893
|
||
Updated•2 years ago
|
Assignee: nobody → mreschenberg
Status: NEW → ASSIGNED
Pushed by mreschenberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3578759b7e5f Traverse embedded chars when computing text bounds. r=Jamie
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•