[wpt-sync] Sync PR 33963 - Disable incremental styling for animated ComputedStyles
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33963 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33963
Details from upstream follow.
Anders Hartvoll Ruud <andruud@chromium.org> wrote:
Disable incremental styling for animated ComputedStyles
For ComputedStyles that are affected by animation effects, we also
store the corresponding base style on that animated ComputedStyle.
This currently interacts poorly with incremental styling, since we copy
the (potentially animated) ComputedStyle from the Element, which may
already have the base style stored. StyleResolver::ApplyAnimatedStyle
may then store that style as a base style again, potentially creating
an infinite chain of base styles.This problem can't be reproduced with DCHECKs enabled, since we
call ApplyBaseStyleNoCache to verify that the incremental
ComputedStyle is equal to the ComputedStyle we would produce with a
full resolution. However, the diff is blind to to fields which aren't
generated, which includes the BaseData.Bug: 1313554
Change-Id: I24ce40b7ec9a54f818098b21e1125f0071c11b24
Reviewed-on: https://chromium-review.googlesource.com/3629398
WPT-Export-Revision: 6c6445b92860537ea07a5eef0013cb161de83dcd
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
CI Results
Ran 8 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Description
•