1768201 - The Fast Forward/Backward commands are unavailable in the PiP window on Netflix

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Ada C.]

Note

• When the user launches the PiP for the first time in a fresh profile on Netflix, it will display at the very bottom-right edge and the user can forward/backward the video by tapping on the right/left keyboard arrows, he will notice that the video is not being skipped forward/backward.

Affected versions

• Nightly v102.0a1
• Beta v101.0b2
• Release

Affected platforms

• Windows 10 x64
• Mac OS 11.6 (Big Sur)
• Ubuntu 20.04

Steps to reproduce

1. Launch browser in a new profile.
2. Play any video.
3. Launch the PiP window.
4. Tap the right/left arrows on the keyboard.

Expected result

• The user is able to seek forward/backward the video.

Actual result

• The used is unable to seek forward/backward the video.

Regression range

• This appears to be a regression, however it can't be investigated while the Widevine issue still reproduces. (1767953)

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Hmm. I would be surprised if this were a regression; my expectation would be that these buttons never worked, as the pause button didn't until we manually patched it in bug 1752132.

Comment 2

[kpatenio]

Currently we're running fallback functions when we fast forward/go backwards with left or right arrow keys (searchfox). We may need to leverage the Netflix player API like we did for the pause/play button.

Comment 3

[Molly Howell (she/her) (mostly inactive)]

(In reply to kpatenio from comment #2)

Currently we're running fallback functions when we fast forward/go backwards with left or right arrow keys (searchfox). We may need to leverage the Netflix player API like we did for the pause/play button.

Do you happen to have any availability to look into that angle? If not I'll see what I can do.

Comment 4

[kpatenio]

(In reply to Molly Howell (she/her) [:mhowell] from comment #3)

(In reply to kpatenio from comment #2)

Currently we're running fallback functions when we fast forward/go backwards with left or right arrow keys (searchfox). We may need to leverage the Netflix player API like we did for the pause/play button.

Do you happen to have any availability to look into that angle? If not I'll see what I can do.

I have availability at the moment. I can take an initial look at the problem.

Comment 5

[kpatenio]

Attachment: Bug 1768201 - add seek forward and backward key shortcuts for pip on netflix. r=#pip-reviewers!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f13cd65b345
add seek forward and backward key shortcuts for pip on netflix. r=pip-reviewers,mhowell

Comment 7

[kpatenio]

Comment on attachment 9275633 [details]
Bug 1768201 - add seek forward and backward key shortcuts for pip on netflix. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Firefox users that have PiP enabled for a Netflix video won't be able to seek backwards/forward in the video's timeline using the left or right arrow keyboard shortcuts. This is inconsistent with other major sites like YouTube and Prime Video, where the left/right arrow shortcuts work as expected. To improve PiP usability for all PiP users, we should have this fix merged in as soon as possible.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Navigate to Netflix

2. Watch a video
3. Enable Picture in Picture mode via PiP toggle or context menu (after right clicking) on the video
4. Click on the pip window that appears on screen
5. Test keyboard shortcuts: press left arrow key to go backwards, right arrow key to move forwards, home button to go to the start of the video, end button to go to the end of the video

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix only affects Netflix. Even if the fix fails to work for some reason, it will not break Picture in Picture as a whole; the shortcuts would simply not work in that case. (Regarding automated tests: we do not have automated tests specifically for Netflix, since we do not have the capability to test site specific video wrappers with live sites right now. However, we already have tests that verify overall keyboard shortcut functionality for PiP).
• String changes made/needed: None
• Is Android affected?: No

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9f13cd65b345

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275633 [details]
Bug 1768201 - add seek forward and backward key shortcuts for pip on netflix. r=#pip-reviewers!

Approved for 101.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/131abca4a1aa

Comment 11

[Daniel Bodea [:danibodea]]

This fix was verified in Nightly v102.0a1 from 2022-05-11, Beta v101.0b5 on Win10, Mac OS 11 and Ubuntu 22.

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9275633 [details]
Bug 1768201 - add seek forward and backward key shortcuts for pip on netflix. r=#pip-reviewers!

Approved for 100.0.1

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/1e78d2d52f79

Comment 14

[Dianna Smith [:diannaS]]

Reverted only the changes to PictureInPictureChild.jsm in mozilla-release for causing eslint failures
https://hg.mozilla.org/releases/mozilla-release/rev/b9f6183616e104d672e34b00c07e5603d4496133

Comment 15

[Daniel Bodea [:danibodea]]

This fix has also been verified on Release v100.0.1 on Windows 10, Mac OS 11.6.5, Ubuntu 20.04 LTS (X11 Window Protocol), Ubuntu 22.04 LTS (Wayland Window Protocol) and Windows 7. The right and Left arrow buttons seek forward and back while in PiP.