1768209 - "Disable Popup Auto-Hide" not working when trying to inspect overflowing "All Tabs" list panel popup

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Itiel]

STR:

1. Using latest Nightly on Windows 10, fresh profile, enable the toolbox
2. Open many tabs so that the tabbar would overflow and the "List all tabs" button would appear
3. Open the toolbox, select Disable Popup Auto-Hide
4. Click the "List all tabs" button on the tabbar
5. Move back to the toolbox

AR:

1. Sometimes, as soon as you move the cursor back to the toolbox window, the All Tabs list popup is closed but the List All Tabs button is in the mousedown'd state. Clicking it doesn't do anything and you must restart the browser to fix it.
2. Other times, you can inspect that panel, but as soon as you close the toolbox, the same thing happens- the All Tabs list popup is closed but the List All Tabs button is in the mousedown'd state. Clicking it doesn't do anything and you must restart the browser to fix it.

ER:
I should be able to inspect that panel and that panel should work after closing the toolbox.

Comment 2

[Itiel]

pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b360d0fa4d48b5f8fbe160ee92accffabc508624&tochange=e3cd649820706c01265787d202a026ed14e7037c
suspect is bug 1442600

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1442600

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:nchevobbe, since you are the author of the regressor, bug 1442600, could you take a look?
For more information, please visit auto_nag documentation.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

So I can confirm the issue with Bug 1442600 causing the tooltip to be hidden, I'll look into that.
Note that even when reverting the patch, with "Disable Popup Auto-Hide", the all tabs popup can't be hidden by clicking on the button again (Re enabling Popup Auto-Hide makes it possible to close it).

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

I think patch from Bug 1442600 is only revealing an issue that was already existing but that we'd never encounter
Here the popup is hidden when we show the highlighter, which we never did before because of the extra check in isXUL function

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

I'm not a 100% sure, but I suspect that using insertAnonymousContent on a document where we have a XUL popup displayed causes it to disappear.
Emilio, is this a known issue/something expected?

I'll go ahead and fix the specific issue we're seeing, but it might be good to sort this out

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1768209 - [devtools] Fix Disable Popup Auto-Hide + Browser Toolbox highlighters. r=emilio.

Using insertAnonymousContent on a document where a XUL popup is displayed seems
to hide/destroy it.
This patch extends the current behaviour for XUL windows to Chrome windows:
we add an iframe in the document which will contain the anonymous content.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

insertAnonymousContent for the first time in a document causes frame reconstruction of the whole document (somewhat expectedly).

That in turn is expected to close XUL popups. It should be feasible I think to implement more fine-grained invalidation of the anonymous content in particular in the frame constructor, though haven't looked at how easy or hard it'd be.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)

insertAnonymousContent for the first time in a document causes frame reconstruction of the whole document (somewhat expectedly).

That in turn is expected to close XUL popups. It should be feasible I think to implement more fine-grained invalidation of the anonymous content in particular in the frame constructor, though haven't looked at how easy or hard it'd be.

Oh okay, thanks for the explanation.
I filed Bug 1768896 if we ever want to try to address this issue, and I'll add it as a reference in the patch for this bug.

I was wondering if I could workaround this another way, trying to retrieve the opened popups and reopen them after calling insertAnonymousContent, but I'm afraid this would trigger unexpected events/behavior :/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0233126a398
[devtools] Fix Disable Popup Auto-Hide + Browser Toolbox highlighters. r=emilio.

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d0233126a398

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #13)

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Browser Toolbox only issue and the fix didn't include automated test, so I'd rather not uplift it