1768410 - event summary dialog: when maximizing, the attendees area also gets larger

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[adrien.rybarczyk]

Attachment: interfaceBeta.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.88 Safari/537.36

Steps to reproduce:

1. Open an invitation event

Actual results:

In beta version, when we expand the interface, it will be mainly the attendees area that will expand.

In version 91, the description part is expanded.

Expected results:

The behavior of the beta version is better for the visualization of the attendees, but this part is perhaps growing too fast compared to the description part.

Comment 1

[adrien.rybarczyk]

Attachment: interface91.PNG

Comment 2

[Lasana Murray]

Seems like some code removed in bug 1763443 lead to this. This is a terrible hack, hopefully we can re-design these dialogs to be pure html soon.

Comment 3

[Lasana Murray]

Attachment: Bug 1768410 - Put splitter between attendee list and description in summary dialog. r=aleca

Comment 4

[Alessandro Castellani [:aleca]]

I don't think we should add this JS calculation of height as you indeed pointed out, it's a terrible hack :D

In terms of UX, being able to expand the list of attendees is very useful, especially when having more than 4 or 5 attendees as scrolling a 2 lines list is horrible.

As a temporary solution, I'd suggest to add a splitter between the two sections, so users can resize the 2 areas the way they want.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd17445bc704
Put splitter between attendee list and description in summary dialog. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug 1768410 - Remove the top border on Windows. r=aleca

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f051f4be0285
Remove the top border on Windows. r=aleca

Comment 8

[Lasana Murray]

Attachment: Bug 1768410: Follow up, hide splitter when there is no description or attendees. r=aleca

Comment 9

[Lasana Murray]

Please land the latest patch on trunk. Thank you.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e049e25c4a9a
Follow up, hide splitter when there is no description or attendees. r=aleca

Comment 11

[Lasana Murray]

Comment on attachment 9280712 [details]
Bug 1768410: Follow up, hide splitter when there is no description or attendees. r=aleca

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: A peculiar horizontal splitter bar shows up when not needed.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): Low risk.

Comment 12

[Lasana Murray]

Requesting this D148932 be added to 102 also.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9280712 [details]
Bug 1768410: Follow up, hide splitter when there is no description or attendees. r=aleca

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.0beta6:
https://hg.mozilla.org/releases/comm-beta/rev/adae4eb4d20a