1768609 - Optional toolbar button for OpenPGP/S/MIME digital signing

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

For users who want it, it would be good to have a visual feedback that digital signing is enabled, and a quick way to enable/disable it.

Similar to the "Encrypt" toolbar button we're adding with the work for bug 1627956 (and bug 1764324), we could have an additional "Sign" button.

Magnus suggested we should have it hidden by default, and require that users use "toolbar customize" to get it.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1768609 - Optional toolbar button for OpenPGP/S/MIME digital signing. r=mkmelin

Depends on D145350

Comment 2

[Kai Engert [:KaiE:]]

I showed this to Alex. His initial reaction was positive, having this optional button seemed fine to him.

He didn't like that the toolbar button in the disabled state shows a faded-out signature icon. Alex would prefer to have an icon that looks different in the signing state.

He was ok to change to a different icon in a follow-up. I'm happy to accept different icons, for me it's important we have some kind of button at all (customizable).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f912319c976
Optional toolbar button for OpenPGP/S/MIME digital signing. r=mkmelin

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9275826 [details]
Bug 1768609 - Optional toolbar button for OpenPGP/S/MIME digital signing. r=mkmelin

let's test functionality intended for 102 in beta

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9275826 [details]
Bug 1768609 - Optional toolbar button for OpenPGP/S/MIME digital signing. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/05a96f286659