Closed
Bug 1768642
Opened 2 years ago
Closed 2 years ago
Use element's placeholder as a heuristic when trying to match field type
Categories
(Toolkit :: Form Autofill, enhancement, P3)
Toolkit
Form Autofill
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: tgiles, Assigned: tgiles)
References
Details
Attachments
(1 file)
In order to accurately match field types, we should use an element's placeholder (if present) and see if it matches our heuristics. I know this approach will fix Bug 1751159 and possibly other bugs I'm unaware of.
|
Assignee | |
Comment 1•2 years ago
|
||
This fixes the aliexpress case and other cases that I am unaware of.
|
|
Assignee | |
Comment 2•2 years ago
|
||
We want to wait until we have enabled Fathom to recognize credit card fields before landing this patch.
Depends on: 1759418
|
||
Comment 3•2 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tgiles, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(tgiles)
Flags: needinfo?(dlee)
|
||
Comment 4•2 years ago
|
||
We plan to land this patch in 103 (because we want to land the patch after Bug 1759418 is fixed)
Flags: needinfo?(tgiles)
Flags: needinfo?(dlee)
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e7b5fe99c6d Use element's placeholder as a heuristic when trying to match field type. r=sgalich,dimi
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•