1768642 - Use element's placeholder as a heuristic when trying to match field type

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P3)

Description

[Tim Giles [:tgiles]]

In order to accurately match field types, we should use an element's placeholder (if present) and see if it matches our heuristics. I know this approach will fix Bug 1751159 and possibly other bugs I'm unaware of.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1768642 - Use element's placeholder as a heuristic when trying to match field type. r=sgalich!,dimi!

This fixes the aliexpress case and other cases that I am unaware of.

Comment 2

[Tim Giles [:tgiles]]

We want to wait until we have enabled Fathom to recognize credit card fields before landing this patch.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tgiles, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Dimi Lee [:dimi]]

We plan to land this patch in 103 (because we want to land the patch after Bug 1759418 is fixed)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7b5fe99c6d
Use element's placeholder as a heuristic when trying to match field type. r=sgalich,dimi

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5e7b5fe99c6d