Closed Bug 1768761 Opened 3 years ago Closed 3 years ago

Intermittent /css/css-scroll-snap/input/keyboard.html | Snaps to top-left after pressing ArrowUp / ArrowLeft - assert_greater_than: expected a number greater than 2 but got 1

Categories

(Core :: Layout: Scrolling and Overflow, defect, P5)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1785551

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=377634283&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YfLkEI4mSSKM7PV3s3BKFA/runs/0/artifacts/public/logs/live_backing.log


[task 2022-05-11T00:36:16.649Z] 00:36:16     INFO - TEST-START | /css/css-tables/table-model-fixup-2.html
[task 2022-05-11T00:36:16.653Z] 00:36:16     INFO - Closing window 87f67f4c-80b7-4128-ae2c-bf36b0e8418b
[task 2022-05-11T00:36:16.865Z] 00:36:16     INFO - 
[task 2022-05-11T00:36:16.865Z] 00:36:16     INFO - TEST-FAIL | /css/css-scroll-snap/input/keyboard.html | Snaps to bottom-left after pressing ArrowDown - assert_greater_than: expected a number greater than 2 but got 2
[task 2022-05-11T00:36:16.865Z] 00:36:16     INFO - @http://web-platform.test:8000/css/css-scroll-snap/input/keyboard.html:52:22
[task 2022-05-11T00:36:16.865Z] 00:36:16     INFO - TEST-UNEXPECTED-FAIL | /css/css-scroll-snap/input/keyboard.html | Snaps to top-left after pressing ArrowUp - assert_greater_than: expected a number greater than 2 but got 1
[task 2022-05-11T00:36:16.865Z] 00:36:16     INFO - @http://web-platform.test:8000/css/css-scroll-snap/input/keyboard.html:62:22
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-PASS | /css/css-scroll-snap/input/keyboard.html | Snaps to top-right after pressing ArrowRight 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-PASS | /css/css-scroll-snap/input/keyboard.html | Snaps to top-left after pressing ArrowLeft 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-PASS | /css/css-scroll-snap/input/keyboard.html | If the original intended offset is valid as making a snap area cover thesnapport, and there's no other snap offset in between, use the originalintended offset 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-TIMEOUT | /css/css-scroll-snap/input/keyboard.html | If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset. - Test timed out
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-NOTRUN | /css/css-scroll-snap/input/keyboard.html | If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is mandatory, stay at the current offset. 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-KNOWN-INTERMITTENT-NOTRUN | /css/css-scroll-snap/input/keyboard.html | If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is proximity, go to the original intended offset 
[task 2022-05-11T00:36:16.871Z] 00:36:16     INFO - TEST-TIMEOUT | /css/css-scroll-snap/input/keyboard.html | took 10208ms
[task 2022-05-11T00:36:16.872Z] 00:36:16     INFO - PID 8169 | 1652229376868	Marionette	INFO	Stopped listening on port 53995
[task 2022-05-11T00:36:16.966Z] 00:36:16     INFO - ........................................
[task 2022-05-11T00:36:16.967Z] 00:36:16     INFO - TEST-OK | /css/css-tables/table-model-fixup-2.html | took 290ms
[task 2022-05-11T00:36:16.969Z] 00:36:16     INFO - TEST-START | /css/css-tables/table-model-fixup.html

Hi Hiro! Can you please take a look at this? Could this be regressed by Bug 1766192?

Flags: needinfo?(hikezoe.birchill)
Summary: Intermittent /css/css-scroll-snap/input/keyboard.html | Snaps to top-left after pressing ArrowUp - assert_greater_than: expected a number greater than 2 but got 1 → Intermittent /css/css-scroll-snap/input/keyboard.html | Snaps to top-left after pressing ArrowUp / ArrowLeft - assert_greater_than: expected a number greater than 2 but got 1

Hmm this test case is really depending on implementation. From the test case;

  const scrollCounter = new ScrollCounter(t, scroller);
  await keyPress(scroller, "ArrowDown");
  await waitForScrollEnd(scroller, scrollTop, 400);
  // Make sure we don't jump directly to the new snap position.
  assert_greater_than(scrollCounter.count, 2);

So, this test case supposes that browsers do snap once after the scroll triggered by ArrowDown key finished? In our implementation the scroll by key press directly goes toward the snap point, the reason why it often passes, I mean there are 2 scroll events, is the scroll is async. And getting 2 events is just by chance.

See Also: → 1782406
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.