Open Bug 1768869 Opened 4 years ago Updated 16 days ago

The private engine details in the (legacy) telemetry environment are not reset when turning off default private engine

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng][private-search])

Whilst playing around, I just noticed that we don't always reset the telemetry environment for the default private engine.

STR

  • Turn on the UI enabled pref.
  • Set an engine for private mode that's different to the main engine.
  • Check the environment data in about:telemetry
  • Check the "Use this search engine in Private Windows" box
  • Check the environment data again (reload the page)

Expect Results

The environment data is no longer shown for the default private engine.

This would be correctly reset after a restart.

Actual Results

The out of date environment data continues being shown for the default private engine.

Talking to the telemetry team, it seems that we should be ok to do something like delete this._currentEnvironment.settings.defaultPrivateSearchEngine in TelemetryEnvironment.jsm when we don't have those objects.

We should fix this in legacy telemetry and check to see if it affects Glean telemetry as well.

Whiteboard: [sng][private-search]

I checked and this doesn't affect Glean data, we should still fix this for the legacy tables for the time being.

Summary: The private engine details in the telemetry environment are not reset when turning off default private engine → The private engine details in the (legacy) telemetry environment are not reset when turning off default private engine
Priority: P3 → P2
You need to log in before you can comment on or make changes to this bug.