Open
Bug 1768874
Opened 2 years ago
Updated 2 years ago
Figure out a better setup for the style crate's unit tests.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
NEW
People
(Reporter: emilio, Unassigned)
References
Details
In bug 1768301, ccov builds failed because using -Clink-dead-code
causes the style crate to pull a bunch of libxul / Gecko code.
In the past there used to be more tests, but at this point, other than the piecewise-linear function tests introduced in bug 1764126, it's mostly a bunch of sizeof
tests.
There are various things that could be done here, but something that looks a bit appealing would be to move the sizeof tests to the style crate itself (to happen at build-time, like a static_assert), and maybe move the piecewise linear function to a separate crate (since it doesn't depend on much from the style crate, actually).
Then we can remove these tests altogether.
Updated•2 years ago
|
Severity: -- → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•