1768903 - Cursor gets hidden when executing various keyboard shortcuts

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Itiel]

STR:
Using Windows 10 and latest Nightly, execute various keyboard shortcuts like Ctrl+H, Ctrl+I, Ctrl+L, Ctrl+Shift+J, Ctrl+Shift+Alt+I and many many more.

AR:
The cursor gets hidden for a second or so.

ER:
IMO it shouln't.

Due to https://phabricator.services.mozilla.com/D143849 this doesn't affect the common Ctrl+C, Ctrl+V etc. but this doesn't seem inclusive and I'd expect the hiding-mechanism to not hide the cursor if the Ctrl key was first clicked.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1759558

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:handyman, since you are the author of the regressor, bug 1759558, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[David Parks [:handyman]]

We've also been experimenting and it does seem that ctrl key sequences are best left out of the cursor-hiding test.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Seems like something we probably want to address before 101 goes to RC next week.

Comment 5

[David Parks [:handyman]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

Seems like something we probably want to address before 101 goes to RC next week.

Patch is coming but I don't think this is important enough to cause the mouse-hiding feature to be held back or anything. This issue is very minor -- if you only enter ctrl-key sequences into some text field, then this will hide the cursor until the mouse is moved again, as it (now) does for non-ctrl-keys. That's a pretty extreme case and it's resolved simply by moving the mouse to restore the pointer.

Comment 6

[David Parks [:handyman]]

Attachment: Bug 1768903: Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin!

Previously, we ignored cut-and-paste operations, similar to some other applications, but most ctrl-keys do something in the browser that makes hiding the cursor pointless or distracting (like ctrl-j opening the download window).

Comment 7

[Itiel]

(In reply to David Parks [:handyman] from comment #5)

if you only enter ctrl-key sequences into some text field

FTR this can happen regardless of text fields.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the bug is marked as tracked for firefox102 (nightly) and tracked for firefox101 (beta).
:handyman, could you consider increasing the severity of this tracked bug?

For more information, please visit auto_nag documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f26e29f4be92
Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin

Comment 10

[Okarin]

I have experienced this with browser back/forward keys and I have found that many other keys hide the cursor even if they are not related to typing: function keys (VK_F*), browser keys (VK_BROWSER_), media keys (VK_MEDIA_), volumes keys (VK_VOLUME_*) etc.

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f26e29f4be92

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:handyman, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Chris Martin [:cmartin]]

Comment on attachment 9276794 [details]
Bug 1768903: Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin!

Beta/Release Uplift Approval Request

• User impact if declined: Mouse will continue to vanish for "Ctrl-<key>" combinations, which some users may find annoying
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change isn't risky because the code is small, contained, well-understood, and the behavioral change is very minor and unlikely to even be noticed by users who don't care one way or another
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9276794 [details]
Bug 1768903: Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin!

Approved for 101.0rc2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/ac4517f8d669

Comment 16

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2022-05-11, on Win 10 x64.

Verified as fixed on Firefox 101.0 (20220526203855) and 102.0a1 (20220530093943). The cursor doesn't hide anymore when using Ctrl + key shortcuts.