Closed Bug 1768972 Opened 1 year ago Closed 1 year ago

DocAccessibleParent::AddChildDoc calls RecvEvent causing monitor lock reentry

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
All
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ctw-m1])

Attachments

(1 file)

Bug 1768972 - Introduce FireEvent to avoid android monitor lock reentry. r?Jamie
48 bytes, text/x-phabricator-request
Details | Review

If an inner doc is added via BrowserParent::RecvPDocAccessibleConstructor it will call DocAccessibleParent::AddChildDoc which will call DocAccessibleParent::RecvEvent.

Both Recv functions hold a monitor auto lock and we end up hanging.

We rely on Recv events to be called from child processes and not from
other Recv events. If this happens we risk reentry in regards to the
android monitor lock.

Attachment #9276172 - Attachment description: Bug 1768972 - Introduce RecvEventInner to avoid android monitor lock reentry. r?Jamie → Bug 1768972 - Introduce FireEvent to avoid android monitor lock reentry. r?Jamie
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6c88376ddfc
Introduce FireEvent to avoid android monitor lock reentry. r=Jamie
Whiteboard: [ctw-m1]
Severity: -- → S3

https://hg.mozilla.org/mozilla-central/rev/d6c88376ddfc

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.