1769009 - Reloading a page doesn't refresh the list of Web MIDI devices

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gabriele Svelto [:gsvelto]]

This is a rather major issue given we don't support hotplug and very easy to reproduce. Here's my STR:

1. Force-enabled Web MIDI support via prefs or changing the code in MIDIPermissionRequest.cpp
2. Plug a MIDI device
3. Browse to https://www.midimonitor.com/
4. Click on the "Devices" button, your device will show up
5. Unplug the MIDI device
6. Reload the page
7. Click on the "Devices" button again, your device still shows up

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1769009 - Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69f265c469f6
Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot

Comment 3

[Marian-Vasile Laza]

Backed out changeset 69f265c469f6 (Bug 1769009) for causing mochitest failures on test_midi_device_explicit_open_close.html.
Backout link
Push with failures <--> 12
Failure Log

Comment 4

[Gabriele Svelto [:gsvelto]]

Refreshing the test MIDI devices list is causing spurious statechange events on the MIDIAccess object which are causing other tests to fail. I need to change the test implementation to refresh the list in a more controllable way to prevent those.

Comment 5

[Gabriele Svelto [:gsvelto]]

I've altered the test, try is looking good, I'll land again.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f282648916d5
Refresh the list of MIDI devices both when navigating to a new page and away from an old one r=padenot

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f282648916d5