1769029 - Support ESM loaded by shim in loadedModules

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

Cu.loadedModules returns a list of URI of loaded JSMs

Comment 1

[Tooru Fujisawa [:arai]]

The problem with loadedModules is that, we don't track whether the ESM is loaded by shim or not,
so, possible options are:

• (a) add extra flag to ModuleScript for "loaded by shim" and return flagged modules, mapping to .jsm URL
• (b) add extra map/set for "ESM loaded by shim"
• (c) just return all ESMs, mapping to .jsm URL

Comment 2

[Tooru Fujisawa [:arai]]

the patch takes (c)

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769029 - Support ESM loaded by shim in Cu.loadedModules. r?yulia!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da102935dfd2
Support ESM loaded by shim in Cu.loadedModules. r=yulia

Comment 5

[Cristian Tuns]

Backed out for causing spidermonkey failures on Modules.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/src/vm/Modules.cpp:237:10: error: cannot initialize return object of type 'JSObject *' with an rvalue of type 'js::ModuleEnvironmentObject *'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c35723786c0
Support ESM loaded by shim in Cu.loadedModules. r=yulia

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7c35723786c0