1769085 - Fix PBM tests to handle opening Spotlight

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Fix of Bug 1765907 , tried to invoke Spotlight flow from test file 'browser_privatebrowsing_about_nimbus_messaging.js' using Sinon causing two backout of the patch due to intermittents.

https://phabricator.services.mozilla.com/D144871

Scope of this bug is to investigate intermittent failure seen with patch and refactor test to handle opening spotlight from tests in PBM mode.

Gist below shows the stub usage in test
https://gist.github.com/punamdahiya/8c9922a4acea3ace1c753dc44fb85199

With this Stub usage in 'browser_privatebrowsing_about_nimbus_messaging.js, intermittent failure was seen in browser_privatebrowsing_focus_promo.js due to not able to show promo

https://treeherder.mozilla.org/jobs?repo=try&author=pdahiya%40mozilla.com&selectedTaskRun=abpWjvG5TlWQI2NdJIOEDg.0&searchStr=Linux%2C18.04%2Cx64%2CWebRender%2Casan%2Copt%2CMochitests%2Cwith%2Csoftware%2Cwebrender%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-asan-qr%2Fopt-mochitest-browser-chrome-swr-fis-e10s%2Cbc2

If stub calls are changed to spy , intermittent failure below is seen for different tests on linux in private browsing browser_privatebrowsing_localStorage.js , browser_privatebrowsing_noSessionRestoreMenuOption.js, browser_privatebrowsing_protocolhandler.js

A promise chain failed to handle a rejection: Could not get children of file(/tmp/tmp9c8f4krj.mozrunner/settings/main/ms-images) because it does not exist - stack: (No stack available.)

https://treeherder.mozilla.org/logviewer?job_id=377220226&repo=autoland&lineNumber=19988

https://mozilla.slack.com/archives/G90HG2UQH/p1652141301328679?thread_ts=1652119806.446959&cid=G90HG2UQH

Comment 1

[Punam Dahiya [:pdahiya]]

Fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1759214 should help with below error seen due to issue around remote images cleanup

A promise chain failed to handle a rejection: Could not get children of file(/tmp/tmp9c8f4krj.mozrunner/settings/main/ms-images) because it does not exist - stack: (No stack available.)

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1769085 - Fix PBM tests to handle opening Spotlight

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b65557af5363
Fix PBM tests to handle opening Spotlight r=mviar

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b65557af5363