1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Jonathan Watt [:jwatt]]

Follow-up from bug 1712104.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c66a1b9c927c
Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 9276333 [details]
Bug 1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: In bug 1712104 I added functionality to print directly using the system print dialog. The dialog opened in that scenario fails to pay attention to whether there's a selection in the document to be printed though, so doesn't enable the "Print selection only" radio button in the dialog. This is a fairly trivial fix and will avoid users being annoyed by that.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Set pref print.prefer_system_dialog to true, open a page with text, then try printing with/without selecting some of the text. The "Print selection only" radio button should only be enabled (or shown) if there is a selection in the page, and printing with that radio checked should only print the selection.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch essentially just adds a missing call to the function that checks if there is a selection, and flags the fact there's a selection to the native dialog.
• String changes made/needed:
• Is Android affected?: Yes

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/c66a1b9c927c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9276333 [details]
Bug 1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer

Approved for 101.0b7.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2a4276c5c33b

Comment 7

[Giorgia Nichita, Release Desktop QA]

I have reproduced this issue on an affected Nightly build from 2022-05-12, on Win 10 x64.

Verified as fixed on Firefox 101.0b7 (20220515185854) and Firefox 102.0a1 (20220517092745) on Windows 10 x64, macOS 10.14 and Ubuntu 21.04.
With 'print.prefer_system_dialog' set to true, the "Print selection only" radio button is enabled in the system print dialog when there is a selection in the document.