1769134 - [wpt-sync] Sync PR 34048 - Reland "Avoid unnecessary calls to paint invalidation"

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34048
Details from upstream follow.

Kevin Ellis <[e-mail]> wrote:

Reland "Avoid unnecessary calls to paint invalidation"

The original patch was reverted due to a memory size regression
(crbug.com/1323173) and a test flake (crbug.com/1291090).

In the original patch, the size of an ElementAnimations increased due
to the addition of a data member with an enumerated value. This size
increase was addressed by packing the new enumerated value and the
boolean valued data member into a bitfield.

The test flake was caused by a DCHECK failure, which in turn was the
result of a faulty assumption about when an animation can be composited.
Once a composited animation is downgraded to a main thread animation, it
cannot become a composited animation without a pending animation update.
Thus, it is possible for CheckCanStartAnimationOnCompositor to return
kNoFailure even if the animation will remain running on the main thread.

Bug: 1301961
Change-Id: I1702eb5485c62a77cb2a1e740ced04a06c2f25ce

Reviewed-on: https://chromium-review.googlesource.com/3644990
WPT-Export-Revision: 150aafc2e93cc1287637dd0bf7a168e15c1d9c1f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=339cc032d3afcca11364f2b964aa8eb4df38ef7e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 2

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47aa17306a84
[wpt PR 34048] - Reland "Avoid unnecessary calls to paint invalidation", a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/47aa17306a84